Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/jaegerreceiver] Add logs when the respective server starts in jaegerreceiver #36961

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+38 −1
Open

[receiver/jaegerreceiver] Add logs when the respective server starts in jaegerreceiver #36961

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
19cff4a
feat[jaeger-receiver]: log the endpoint of the server listening
Saumya40-codes Dec 26, 2024
0090b57
fix: use meaningful description during logging info
Saumya40-codes Dec 26, 2024
adafb33
remove kind and name fields (handled by default)
Saumya40-codes Dec 27, 2024
364d4be
Merge branch 'main' into log-endpoints
yurishkuro Dec 27, 2024
c5cd657
addressed reviewed changes
Saumya40-codes Dec 27, 2024
5482948
Merge branch 'log-endpoints' of https://github.com/Saumya40-codes/ope…
Saumya40-codes Dec 27, 2024
9b8e2ae
add chlog
Saumya40-codes Dec 27, 2024
4db9280
update chlog
Saumya40-codes Dec 27, 2024
f3c94d2
tidy (re: deps change)
Saumya40-codes Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions receiver/jaegerreceiver/trace_receiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import (
"go.opentelemetry.io/collector/receiver"
"go.opentelemetry.io/collector/receiver/receiverhelper"
"go.uber.org/multierr"
"go.uber.org/zap"
"google.golang.org/grpc"

jaegertranslator "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/jaeger"
Expand Down Expand Up @@ -247,6 +248,8 @@ func (jr *jReceiver) startAgent(host component.Host) error {
return err
}
jr.agentProcessors = append(jr.agentProcessors, processor)

jr.settings.Logger.Info("Starting UDP server for Binary Thrift", zap.String("endpoint", jr.config.AgentBinaryThrift.Endpoint))
}

if jr.config.AgentCompactThrift.Endpoint != "" {
Expand All @@ -267,6 +270,8 @@ func (jr *jReceiver) startAgent(host component.Host) error {
return err
}
jr.agentProcessors = append(jr.agentProcessors, processor)

jr.settings.Logger.Info("Starting UDP server for Compact Thrift", zap.String("endpoint", jr.config.AgentCompactThrift.Endpoint))
}

jr.goroutines.Add(len(jr.agentProcessors))
Expand All @@ -280,6 +285,8 @@ func (jr *jReceiver) startAgent(host component.Host) error {
if jr.config.AgentHTTPEndpoint != "" {
jr.agentServer = httpserver.NewHTTPServer(jr.config.AgentHTTPEndpoint, &notImplementedConfigManager{}, metrics.NullFactory, jr.settings.Logger)

jr.settings.Logger.Info("Starting HTTP server for Jaeger Agent", zap.String("endpoint", jr.config.AgentHTTPEndpoint))

Saumya40-codes marked this conversation as resolved.
Show resolved Hide resolved
jr.goroutines.Add(1)
go func() {
defer jr.goroutines.Done()
Expand Down Expand Up @@ -388,6 +395,8 @@ func (jr *jReceiver) startCollector(ctx context.Context, host component.Host) er
return err
}

jr.settings.Logger.Info("Starting HTTP server for Jaeger Collector", zap.String("endpoint", jr.config.HTTPServerConfig.Endpoint))
Saumya40-codes marked this conversation as resolved.
Show resolved Hide resolved

jr.goroutines.Add(1)
go func() {
defer jr.goroutines.Done()
Expand All @@ -411,6 +420,8 @@ func (jr *jReceiver) startCollector(ctx context.Context, host component.Host) er

api_v2.RegisterCollectorServiceServer(jr.grpc, jr)

jr.settings.Logger.Info("Starting gRPC server for Jaeger Collector", zap.String("endpoint", jr.config.GRPCServerConfig.NetAddr.Endpoint))
Saumya40-codes marked this conversation as resolved.
Show resolved Hide resolved

jr.goroutines.Add(1)
go func() {
defer jr.goroutines.Done()
Expand Down