Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/jaegerreceiver] Add logs when the respective server starts in jaegerreceiver #36961

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Saumya40-codes
Copy link

@Saumya40-codes Saumya40-codes commented Dec 26, 2024

Description

  • This PR adds the logging related to the server starting under the jaegerreceiver
  • Added logs when: AgentHTTP, GRPC, Thrift Http, Thrift Binary and Thrift compact server starts

Link to tracking issue

Fixes jaegertracing/jaeger#6412

How was change tested?

Running collector with jaegerreceiver enabled with its all transports

Output

@Saumya40-codes ➜ /workspaces/opentelemetry-collector-contrib (log-endpoints) $ ./bin/otelcontribcol_linux_amd64 --config config.yaml
2024-12-27T15:37:23.428Z        info    service@v0.116.1-0.20241220212031-7c2639723f67/service.go:164   Setting up own telemetry...
2024-12-27T15:37:23.428Z        info    telemetry/metrics.go:70 Serving metrics {"address": "localhost:8888", "metrics level": "Normal"}
2024-12-27T15:37:23.428Z        info    builders/builders.go:26 Development component. May change in the future.        {"kind": "exporter", "data_type": "traces", "name": "debug"}
2024-12-27T15:37:23.436Z        info    service@v0.116.1-0.20241220212031-7c2639723f67/service.go:230   Starting otelcontribcol...      {"Version": "0.116.0-dev", "NumCPU": 2}
2024-12-27T15:37:23.436Z        info    extensions/extensions.go:39     Starting extensions...
2024-12-27T15:37:23.436Z        info    jaegerreceiver@v0.116.0/trace_receiver.go:252   Starting UDP server for Binary Thrift   {"kind": "receiver", "name": "jaeger", "data_type": "traces", "endpoint": "0.0.0.0:6831"}
2024-12-27T15:37:23.436Z        info    jaegerreceiver@v0.116.0/trace_receiver.go:274   Starting UDP server for Compact Thrift  {"kind": "receiver", "name": "jaeger", "data_type": "traces", "endpoint": "0.0.0.0:6832"}
2024-12-27T15:37:23.436Z        info    jaegerreceiver@v0.116.0/trace_receiver.go:398   Starting HTTP server for Jaeger Collector       {"kind": "receiver", "name": "jaeger", "data_type": "traces", "endpoint": "0.0.0.0:14268"}
2024-12-27T15:37:23.436Z        info    jaegerreceiver@v0.116.0/trace_receiver.go:423   Starting gRPC server for Jaeger Collector       {"kind": "receiver", "name": "jaeger", "data_type": "traces", "endpoint": "0.0.0.0:14250"}
2024-12-27T15:37:23.436Z        info    service@v0.116.1-0.20241220212031-7c2639723f67/service.go:253   Everything is ready. Begin running and processing data.

config file used

receivers:
  jaeger:
    protocols:
      grpc:
        endpoint: "0.0.0.0:14250"
      thrift_http:
        endpoint: "0.0.0.0:14268"
      thrift_binary:
        endpoint: "0.0.0.0:6831"
      thrift_compact:
        endpoint: "0.0.0.0:6832"
        
exporters:
  debug: {}

service:
  pipelines:
    traces:
      receivers: [jaeger]
      exporters: [debug]

Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
Copy link

linux-foundation-easycla bot commented Dec 26, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
@yurishkuro
Copy link
Member

please include a sample output of running a collector with jaeger receiver enabled (with all its transports) to show logs in action

@Saumya40-codes
Copy link
Author

please include a sample output of running a collector with jaeger receiver enabled (with all its transports) to show logs in action

I've added the same in the PR description. Should anything be changed?

@yurishkuro
Copy link
Member

nothing looks odd to you in the output? Why do you need to repeat "kind": "receiver", "name": "jaeger"?

Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
@Saumya40-codes
Copy link
Author

Saumya40-codes commented Dec 27, 2024

nothing looks odd to you in the output? Why do you need to repeat "kind": "receiver", "name": "jaeger"?

Apologies, I overlooked there and didnt identify that it's been updated/added by default.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a ./.chloggen/ entry

receiver/jaegerreceiver/trace_receiver.go Outdated Show resolved Hide resolved
receiver/jaegerreceiver/trace_receiver.go Outdated Show resolved Hide resolved
receiver/jaegerreceiver/trace_receiver.go Outdated Show resolved Hide resolved
Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
.chloggen/log-jaegerreceiver-endpoints.yaml Outdated Show resolved Hide resolved
.chloggen/log-jaegerreceiver-endpoints.yaml Outdated Show resolved Hide resolved
.chloggen/log-jaegerreceiver-endpoints.yaml Outdated Show resolved Hide resolved
Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
@yurishkuro
Copy link
Member

need to run make gotidy

Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log the ports that jaegerreceiver listens to
3 participants