[exporter/elasticsearch] Add summary support for metrics #34560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
approved these changes
Aug 9, 2024
MovieStoreGuy
approved these changes
Aug 11, 2024
codeboten
reviewed
Aug 12, 2024
There was a problem hiding this comment.
Looks like a couple of checks are failing:
Error: elasticsearchexporter/utils_test.go:39:69: `assertItemsEqual` - `assertOrder` always receives `false` (unparam)
level=info msg="[runner] linters took 16.095711067s with stages: goanalysis_metalinter: 16.088054729s"
level=info msg="File cache stats: 24 entries of total size 218.1KiB"
func assertItemsEqual(t *testing.T, expected, actual []itemRequest, assertOrder bool) {
|
@codeboten It should be fixed in an earlier PR #34471. Merge main and rerunning checks now. |
codeboten
approved these changes
Aug 12, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…try#34560) Add summary support for metrics Added exporter test Fixes open-telemetry#34561 --------- Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add summary support for metrics
Link to tracking Issue:
Testing:
Added exporter test
Documentation: