[chore][exporter/elasticsearch] Refactor passthrough field handling for OTel mode #34471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonip
changed the title
lahsivjar
reviewed
Aug 7, 2024
felixbarny
reviewed
Aug 9, 2024
Comment on lines
+305
to
+306
| "data_stream.dataset": "resource.attribute.dataset", | ||
| "data_stream.namespace": "resource.attribute.namespace", |
There was a problem hiding this comment.
Just as a question: have we implemented sanitization for these already? For example, would resource-attribute-dataset be sanitized to resource_attribute_dataset?
There was a problem hiding this comment.
Nice catch, we have not. Will address in a different PR.
ycombinator
approved these changes
Aug 9, 2024
andrzej-stencel
approved these changes
Aug 12, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…or OTel mode (open-telemetry#34471) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> - **Add otel mapping mode logs test** - **Add note and remove confusing test** There is no change in behavior. No changelog needed. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> Added exporter test **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There is no change in behavior. No changelog needed.
Link to tracking Issue:
Testing:
Added exporter test
Documentation: