Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] try out macos-14 to run arm tests #33921

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Jul 4, 2024

As documented in this blog post https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

The actuated runner has been causing build failures pretty consistently on main. Possibly fix the following flaky tests:

Fixes #32391
Fixes #32395
Fixes #32839

@codeboten codeboten requested review from a team and djaglowski July 4, 2024 14:55
@codeboten codeboten added the Run ARM Enable running ARM tests on a PR label Jul 4, 2024
@codeboten codeboten requested a review from dmitryax as a code owner July 4, 2024 17:13
@github-actions github-actions bot requested a review from braydonk July 4, 2024 17:14
codeboten added a commit to codeboten/opentelemetry-collector that referenced this pull request Jul 4, 2024
Similar to open-telemetry/opentelemetry-collector-contrib#33921

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested a review from jpkrohling as a code owner July 4, 2024 17:51
@github-actions github-actions bot requested a review from frzifus July 4, 2024 17:52
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this fixes #32839 too

There are still test failures - not sure how much they are related

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚢

codeboten added a commit to open-telemetry/opentelemetry-collector that referenced this pull request Jul 12, 2024
Similar to
open-telemetry/opentelemetry-collector-contrib#33921

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 31, 2024
@pureklkl
Copy link
Contributor

Hi, when will this PR will be merged?
I am working on #33393 and planned to add macos runners for testing. I also faced the same test failures which were fixed in this PR.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten merged commit 6a41efc into open-telemetry:main Aug 7, 2024
187 checks passed
@codeboten codeboten deleted the codeboten/fix-arm branch August 7, 2024 19:20
@github-actions github-actions bot added this to the next release milestone Aug 7, 2024
@codeboten
Copy link
Contributor Author

@pureklkl should be good to go now!

f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
As documented in this blog post
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

The actuated runner has been causing build failures pretty consistently
on main. Possibly fix the following flaky tests:

Fixes
open-telemetry#32391
Fixes
open-telemetry#32395
Fixes
open-telemetry#32839

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants