-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support macOS Metrics When CGO Is On #33393
Comments
Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
open-telemetry/opentelemetry-collector-releases#374 You can build your own collector that supports cgo by setting CGO_ENABLED=1. |
Because it was rejected before for linux doesn't preclude we don't consider it for Mac OS. |
There are 2 options to support it
And we will still need mac runners for testing, example, iostat_darwin. |
Sure, are you interested in working on this? |
Yes, please assign to me, I will try the mac runner first. |
ok, if you'd like, you can request a mac runner in the same manner as this large runner was asked for: open-telemetry/community#2156 |
@atoulme @EddieV2 |
Hi @pureklkl, we would want to cover 13, 14, and 15 considering that release will be soon as well and we're preparing for that. 12 would be nice, but isn't much of a concern for us considering 15 being released soon. |
**Description:** <Describe what has changed.> In order to add CGO support, add compatibility test for old macos versions. Due macos-12 and macos-13 are using amd64 instead of arm64, cross compiling is used. **Link to tracking Issue:** <Issue number if applicable> #33393 **Testing:** <Describe what testing was performed and which tests were added.> Added tests for hostmetrics receiver for macos-12 and macos-13 **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
**Description:** <Describe what has changed.> In order to add CGO support, add compatibility test for old macos versions. Due macos-12 and macos-13 are using amd64 instead of arm64, cross compiling is used. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#33393 **Testing:** <Describe what testing was performed and which tests were added.> Added tests for hostmetrics receiver for macos-12 and macos-13 **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Component(s)
receiver/hostmetrics
Describe the issue you're reporting
Currently, CPU and Disk scrapers are not supported on macOS due to the lack of CGO. I understand that this is due to complications with CGO, so I'm asking for these Mac metrics to be turned on while CGO is on.
The text was updated successfully, but these errors were encountered: