Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: memcachedreceiver updated to deprecate operation_hit_ratio metric #33375

Closed
wants to merge 3 commits into from
Closed

[fix]: memcachedreceiver updated to deprecate operation_hit_ratio metric #33375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1f259e
[fix]: memcachedreceiver updated to deprecate operation_git_ratio metric
kernelpanic77 Jun 4, 2024
7bb3b8f
Merge branch 'main' into memcached-receiver
kernelpanic77 Jun 4, 2024
cc686f4
Merge branch 'main' into memcached-receiver
kernelpanic77 Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions receiver/memcachedreceiver/documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,20 +94,6 @@ Bytes transferred over the network.
| ---- | ----------- | ------ |
| direction | Direction of data flow. | Str: ``sent``, ``received`` |

### memcached.operation_hit_ratio

Hit ratio for operations, expressed as a percentage value between 0.0 and 100.0.

| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| % | Gauge | Double |

#### Attributes

| Name | Description | Values |
| ---- | ----------- | ------ |
| operation | The type of operation. | Str: ``increment``, ``decrement``, ``get`` |

### memcached.operations

Operation counts.
Expand All @@ -130,3 +116,27 @@ Number of threads used by the memcached instance.
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| {threads} | Sum | Int | Cumulative | false |

## Optional Metrics

The following metrics are not emitted by default. Each of them can be enabled by applying the following configuration:

```yaml
metrics:
<metric_name>:
enabled: true
```

### memcached.operation_hit_ratio

Hit ratio for operations, expressed as a percentage value between 0.0 and 100.0.

| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| % | Gauge | Double |

#### Attributes

| Name | Description | Values |
| ---- | ----------- | ------ |
| operation | The type of operation. | Str: ``increment``, ``decrement``, ``get`` |
3 changes: 1 addition & 2 deletions receiver/memcachedreceiver/generated_package_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion receiver/memcachedreceiver/internal/metadata/generated_config.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions receiver/memcachedreceiver/internal/metadata/generated_metrics.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion receiver/memcachedreceiver/internal/metadata/generated_metrics_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion receiver/memcachedreceiver/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,12 @@ metrics:
aggregation_temporality: cumulative
attributes: [type,operation]
memcached.operation_hit_ratio:
enabled: true
enabled: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave this as true for at least one release so that users have a chance to adjust before changes are imposed on them.

description: Hit ratio for operations, expressed as a percentage value between 0.0 and 100.0.
warnings:
if_enabled: memcached.operation_hit_ratio is deprecated
if_enabled_not_set: memcached.operation_hit_ratio is deprecated
if_configured: memcached.operation_hit_ratio is deprecated
unit: '%'
gauge:
value_type: double
Expand Down
Loading