[fix]: memcachedreceiver updated to deprecate operation_hit_ratio metric #33375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
reviewed
Jun 4, 2024
| @@ -3,9 +3,8 @@ | |||
| package memcachedreceiver | |||
|
|
|||
| import ( | |||
| "testing" | |||
There was a problem hiding this comment.
This change incorrectly formats go imports, please run make gofmt to fix.
djaglowski
reviewed
Jun 5, 2024
| @@ -117,8 +117,12 @@ metrics: | |||
| aggregation_temporality: cumulative | |||
| attributes: [type,operation] | |||
| memcached.operation_hit_ratio: | |||
| enabled: true | |||
| enabled: false | |||
There was a problem hiding this comment.
We should leave this as true for at least one release so that users have a chance to adjust before changes are imposed on them.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR deprecates memcachedreceiver.operation_hit_ratio, since it does not capture cumulative hit_ratio if the memcached instance restarts
Link to tracking Issue: #30695
Documentation: Documentation updated as per generated config using mdatagen.