Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/kubelet]Add runtime imagesfs metrics for node #26259

Closed
wants to merge 2 commits into from
Closed

[receiver/kubelet]Add runtime imagesfs metrics for node #26259

wants to merge 2 commits into from

Conversation

yantingqiu
Copy link

[receiver/kubelet]Add runtime imagesfs metrics for node

Description:
This PR added runtime imagefs metrics for node.

Testing:

  1. test locally using the otel demo

  2. unit test

@yantingqiu yantingqiu requested a review from a team August 29, 2023 13:39
@yantingqiu yantingqiu force-pushed the add-node-runtime-imagesfs branch from 658448b to 4fd85ba Compare August 29, 2023 13:47
@yantingqiu yantingqiu mentioned this pull request Aug 29, 2023
Closed
TylerHelmuth
TylerHelmuth approved these changes Aug 29, 2023
View reviewed changes
receiver/kubeletstatsreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/kubeletstatsreceiver/metadata.yaml Outdated Show resolved Hide resolved
@yantingqiu yantingqiu force-pushed the add-node-runtime-imagesfs branch from 4fd85ba to 7a27532 Compare August 30, 2023 11:49
@yantingqiu yantingqiu force-pushed the add-node-runtime-imagesfs branch from 7a27532 to dbc7e98 Compare September 1, 2023 14:32
@yantingqiu yantingqiu closed this Sep 4, 2023
@yantingqiu yantingqiu reopened this Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
...beletstatsreceiver/internal/kubelet/accumulator.go 100.00%
...tstatsreceiver/internal/kubelet/runtime_imagefs.go 100.00%
...tatsreceiver/internal/metadata/generated_config.go 100.00%
...atsreceiver/internal/metadata/generated_metrics.go 100.00%

📢 Thoughts on this report? Let us know!.

@yantingqiu yantingqiu force-pushed the add-node-runtime-imagesfs branch from dbc7e98 to 6178ba5 Compare September 7, 2023 15:18
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 4, 2023
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Oct 19, 2023
@jinja2 jinja2 mentioned this pull request Oct 20, 2023
Closed
6 tasks
@yantingqiu yantingqiu deleted the add-node-runtime-imagesfs branch October 25, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinja2 jinja2 jinja2 left review comments

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

@dashpole dashpole

Labels
receiver/kubeletstats Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yantingqiu @TylerHelmuth @jinja2 @dashpole