Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/kubeletstats]Add node runtime imagefs metrics #25880

Closed
wants to merge 1 commit into from
Closed

[receiver/kubeletstats]Add node runtime imagefs metrics #25880

wants to merge 1 commit into from

Conversation

yantingqiu
Copy link

@yantingqiu yantingqiu commented Aug 18, 2023 •
edited
Loading

[receiver/kubelet]Add runtime imagesfs metrics for node

Description:
This PR added runtime imagefs metrics for node.

Testing:

  1. test locally using the otel demo

  2. unit test

@yantingqiu yantingqiu requested a review from dmitryax as a code owner August 18, 2023 09:37
@yantingqiu yantingqiu requested a review from a team August 18, 2023 09:37
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 18, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: yantingqiu / name: ytq (1ba49ba)

@yantingqiu yantingqiu force-pushed the add-node-runtime-imagesfs branch from 1a5e20e to 720cc82 Compare August 18, 2023 12:35
@yantingqiu yantingqiu closed this Aug 18, 2023
@yantingqiu yantingqiu reopened this Aug 18, 2023
@yantingqiu yantingqiu force-pushed the add-node-runtime-imagesfs branch from 720cc82 to 506fe1c Compare August 28, 2023 15:44
@yantingqiu yantingqiu force-pushed the add-node-runtime-imagesfs branch from 506fe1c to 6b07910 Compare August 28, 2023 15:51
TylerHelmuth
TylerHelmuth reviewed Aug 28, 2023
View reviewed changes
receiver/kubeletstatsreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/kubeletstatsreceiver/metadata.yaml Outdated
attributes: []
k8s.node.runtime.imagefs.inodes_used:
enabled: true
description: Node runtime imagefs inodes_used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add in the description that this may not equal Inodes - InodesFree

dmitryax
dmitryax reviewed Aug 28, 2023
View reviewed changes
receiver/kubeletstatsreceiver/metadata.yaml Outdated
@@ -187,6 +187,48 @@ metrics:
monotonic: true
aggregation_temporality: cumulative
attributes: []
k8s.node.runtime.imagefs.available:
enabled: true
Copy link
Member

@dmitryax dmitryax Aug 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New metrics should be added as optional. If they need to be enabled by default, it should be done via a separate process (by adding warnings first) after the metrics are in place. Please see https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/scraping-receivers.md for more details

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very sorry for my foolish mistake that requires me to resubmit the pull request.Thank you for reviewing the code:#26259

@yantingqiu yantingqiu closed this Aug 29, 2023
@yantingqiu yantingqiu force-pushed the add-node-runtime-imagesfs branch from 9db9a18 to 1ba49ba Compare August 29, 2023 12:07
@yantingqiu yantingqiu requested a review from a team August 29, 2023 12:07
@yantingqiu
Copy link
Author

I am very sorry for my foolish mistake that requires me to resubmit the pull request.Thank you for reviewing the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth left review comments

@dmitryax dmitryax dmitryax left review comments

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@arminru arminru Awaiting requested review from arminru

@songy23 songy23 Awaiting requested review from songy23 songy23 is a code owner

@bryan-aguilar bryan-aguilar Awaiting requested review from bryan-aguilar

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner

Assignees

@mx-psi mx-psi

Labels
receiver/kubeletstats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yantingqiu @dmitryax @TylerHelmuth @mx-psi