lokiexporter: Remove dependency on https://github.com/grafana/loki, due to incompatible dep issues #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/pkg/logproto Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
Closed
bogdandrutu
approved these changes
Feb 20, 2021
bogdandrutu
pushed a commit
that referenced
this pull request
Feb 22, 2021
…s for third-party code (#2389) * moved 'logprotos' to 'third_party' directory to follow current project conventions Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com> * moved Loki Apache 2.0 license out to LICENSE file to follow third_party project conventions Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com> * removed otel license header to follow 'third_party' project conventions Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
kisieland
referenced
this pull request
in kisieland/opentelemetry-collector-contrib
Mar 16, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
…ue to incompatible dep issues (#2385) * copied logproto files from https://github.com/grafana/loki/blob/master/pkg/logproto Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com> * updated imports to use local copy of logproto Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com> * fixed import formatting Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com> * added otel copyright to logproto files due to licensecheck Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
…s for third-party code (#2389) * moved 'logprotos' to 'third_party' directory to follow current project conventions Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com> * moved Loki Apache 2.0 license out to LICENSE file to follow third_party project conventions Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com> * removed otel license header to follow 'third_party' project conventions Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
…/otlp/otlptrace (#2385) * Bump github.com/cenkalti/backoff/v4 in /exporters/otlp/otlptrace Bumps [github.com/cenkalti/backoff/v4](https://github.com/cenkalti/backoff) from 4.1.1 to 4.1.2. - [Release notes](https://github.com/cenkalti/backoff/releases) - [Commits](cenkalti/backoff@v4.1.1...v4.1.2) --- updated-dependencies: - dependency-name: github.com/cenkalti/backoff/v4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: MrAlias <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removed dependency on https://github.com/grafana/loki due to incompatible dependency issues. The Grafana/loki project has many dependencies that are not needed by this exporter, and a few of those dependencies have additional dependencies that are incompatible with other components within this project. Given that the "replace" directive is only honored within the root go.mod, these sub-dependencies break other components and prevent this exporter from successfully being added to the binary.
The loki-client-go project was recently started to help address the dependency requirements and make Loki clients easier to implement, but is marked experimental and has not released a version yet. Once this project has released a supported version, we will evaluate switching to it (#2386).
To help progress and overcome these issues immediately, this PR has copied the Loki log protos from ( https://github.com/grafana/loki/tree/v2.1.0/pkg/logproto ), with this decision being documented within the committed exporter/lokiexporter/logproto/README.md.
Link to tracking Issue:
#1894
Testing:
Unit Tests
Documentation:
READMEs