Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test coverage upload failed in CircleCI and reported invalid results for the coverage check #2392

Closed
gramidt opened this issue Feb 21, 2021 · 3 comments
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues Stale

Comments

@gramidt
Copy link
Member

gramidt commented Feb 21, 2021

Describe the bug
In #2385 I added third-party code in a directory that should have caused the code coverage check to fail, but it did not. My code passed the checks and was able to be merged. It turns out there was an error in the 'Upload unit test coverage step' and it didn't report it correctly ( https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/9774/workflows/f6ca94b4-38be-459d-800f-d0658cb96918/jobs/81580/parallel-runs/0/steps/0-105 ).

Steps to reproduce
TBD

What did you expect to see?
The unit test coverage check should have failed.

What did you see instead?
All checks on the PR passed.

What version did you use?
'main' branch.

What config did you use?
N/A

Environment
N/A

Additional context

@gramidt
Copy link
Member Author

gramidt commented Feb 22, 2021

@bogdandrutu - This issue is for tracking what happened with the code coverage check in #2385

kisieland referenced this issue in kisieland/opentelemetry-collector-contrib Mar 16, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@alolita alolita added the ci-cd CI, CD, testing, build issues label Sep 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 4, 2022
@atoulme
Copy link
Contributor

atoulme commented Mar 11, 2023

This is fixed, we now use Github actions.

@atoulme atoulme closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues Stale
Projects
None yet
Development

No branches or pull requests

3 participants