You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Describe the bug
In #2385 I added third-party code in a directory that should have caused the code coverage check to fail, but it did not. My code passed the checks and was able to be merged. It turns out there was an error in the 'Upload unit test coverage step' and it didn't report it correctly ( https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/9774/workflows/f6ca94b4-38be-459d-800f-d0658cb96918/jobs/81580/parallel-runs/0/steps/0-105 ).
Steps to reproduce
TBD
What did you expect to see?
The unit test coverage check should have failed.
What did you see instead?
All checks on the PR passed.
What version did you use?
'main' branch.
What config did you use?
N/A
Environment
N/A
Additional context
The text was updated successfully, but these errors were encountered: