[exporter/prometheusexporter] accumulate delta temporality histograms #23790

hkfgo · 2023-06-27T17:29:43Z

Description:
This continues the work done in the now closed PR. I have addressed issues raised in the original PR by

Adding logic to handle timestamp misalignments
Adding fix + a out-of-bounds bug

In addition, I have performed end-to-end testing in a local setup, and confirmed that accumulated histogram time series are correct.

Link to tracking Issue:
#4968
#9006
#19153
Testing:
Added tests for timestamp misalignment and an out-of-bounds bug discovered in the previous PR.
End-to-end testing to ensure histogram bucket counts exported to Prometheus are correct

…istograms

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

Signed-off-by: Loc Mai <locmai0201@gmail.com>

This reverts commit 21980b454cb0e2ad5a4dcfe35ba4426ef4a41460. Signed-off-by: Loc Mai <locmai0201@gmail.com>

This reverts commit 08022fc9074a445533ab3cd8db22b8874ab4e00c. Signed-off-by: Loc Mai <locmai0201@gmail.com>

Signed-off-by: Loc Mai <locmai0201@gmail.com>

Signed-off-by: xchen <xchen@axon.com>

… bucket boundaries Signed-off-by: xchen <xchen@axon.com>

…ta-prom Chore/rebase nabam delta prom

linux-foundation-easycla · 2023-06-27T17:29:50Z

The committers listed above are authorized under a signed CLA.

✅ login: nabam / name: Lev Popov (574b131, 2385f79, ac88fb9, b96d0f5)
✅ login: locmai / name: Loc Mai (f21cc65, 3c69be1, ba8d644, d9d5b95, 4034315, 3631465, aa6d049, 11bb9a6, 6f805d3, 7b5aa64, 1979cbf, c7d17bb)
✅ login: hkfgo / name: Stephen Chen (e42fcea, 504e3b5, 98c0090, b2e18ca, 3344f60, a52f5af, 107b53b, ca4dde2, fa39587, 5705810, eaa04e2, 231902d, 42a7098, b6e66e3, 7d8b888, 5d6f49d, 2c906ef, a52102d)
✅ login: codeboten / name: Alex Boten (e6f0cef)

Signed-off-by: stephenchen <x.chen1016@gmail.com>

… bucket boundaries Signed-off-by: stephenchen <x.chen1016@gmail.com>

linux-foundation-easycla · 2023-06-27T17:49:22Z

The committers listed above are authorized under a signed CLA.

✅ login: nabam / name: Lev Popov (574b131, 2385f79, ac88fb9, b96d0f5)
✅ login: locmai / name: Loc Mai (f21cc65, 3c69be1, ba8d644, d9d5b95, 4034315, 3631465, aa6d049, 11bb9a6, 6f805d3, 7b5aa64, 1979cbf)
✅ login: hkfgo / name: Stephen Chen (3344f60, a52f5af, 107b53b, ca4dde2, fa39587, 5705810, eaa04e2, 231902d)

github-actions · 2023-10-26T05:19:14Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

hampusrosvall · 2023-10-26T05:37:23Z

Also very interested in this! Happy to help out if needed. How can we get attention from code owners?

hkfgo · 2023-10-26T21:57:10Z

Also very interested in this! Happy to help out if needed. How can we get attention from code owners?

I've been pinging for a review on CNCF Slack.

ggreen53 · 2023-10-26T23:48:24Z

I built this change into a deployed collector and confirmed it works as expected.

jpkrohling · 2023-11-02T09:41:33Z

@sh0rez, can you please review this one?

github-actions · 2023-11-17T05:19:27Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

atoulme · 2023-11-29T00:31:17Z

@jpkrohling @sh0rez are you still looking to review?

exporter/prometheusexporter/accumulator.go

hkfgo · 2023-12-06T23:21:58Z

Thanks for the review @atoulme! I've tidied-up the code a bit following your comments. Would you mind pinging other maintainers to have a look as well?

jpkrohling · 2023-12-08T12:51:41Z

@jpkrohling @sh0rez are you still looking to review?

Sorry about that, I think it's not realistic to wait for a review from us to move forward with this PR.

hkfgo · 2023-12-18T19:53:00Z

@jpkrohling @sh0rez are you still looking to review?

Sorry about that, I think it's not realistic to wait for a review from us to move forward with this PR.

Ack. @atoulme would you be comfortable giving this an approval? It's been thoroughly tested and follows an existing pattern in Prometheus exporter to accumulate delta counters.

gburton1 · 2023-12-28T22:10:22Z

This is approved, and I think it just needs to be merged by an authorized user now. Can someone do that?

…open-telemetry#23790) **Description:** <Describe what has changed.> This continues the work done in the now closed [PR](open-telemetry#20530). I have addressed issues raised in the original PR by - Adding logic to handle timestamp misalignments - Adding fix + a out-of-bounds bug In addition, I have performed end-to-end testing in a local setup, and confirmed that accumulated histogram time series are correct. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#4968 open-telemetry#9006 open-telemetry#19153 **Testing:** <Describe what testing was performed and which tests were added.> Added tests for timestamp misalignment and an out-of-bounds bug discovered in the previous PR. End-to-end testing to ensure histogram bucket counts exported to Prometheus are correct --------- Signed-off-by: Loc Mai <locmai0201@gmail.com> Signed-off-by: xchen <xchen@axon.com> Signed-off-by: stephenchen <x.chen1016@gmail.com> Co-authored-by: Lev Popov <nabam@nabam.net> Co-authored-by: Lev Popov <leo@nabam.net> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Loc Mai <locmai0201@gmail.com> Co-authored-by: Alex Boten <aboten@lightstep.com>

nabam and others added 20 commits August 18, 2022 15:23

[exporter/prometheusexporter] accumulate delta temporality sums and h…

574b131

…istograms

Merge branch 'main' into delta-prom

2385f79

Update exporter/prometheusexporter/accumulator.go

ac88fb9

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

Update exporter/prometheusexporter/accumulator.go

b96d0f5

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

Merge branch 'main' into chore/rebase-nabam-delta-prom

f21cc65

fix tests

3c69be1

Signed-off-by: Loc Mai <locmai0201@gmail.com>

add back aggregation change

ba8d644

Signed-off-by: Loc Mai <locmai0201@gmail.com>

set empty histogram

d9d5b95

Signed-off-by: Loc Mai <locmai0201@gmail.com>

demo

4034315

Signed-off-by: Loc Mai <locmai0201@gmail.com>

Revert "demo"

3631465

This reverts commit 21980b454cb0e2ad5a4dcfe35ba4426ef4a41460. Signed-off-by: Loc Mai <locmai0201@gmail.com>

Revert "Revert "demo""

aa6d049

This reverts commit 08022fc9074a445533ab3cd8db22b8874ab4e00c. Signed-off-by: Loc Mai <locmai0201@gmail.com>

update aggTemporality

11bb9a6

Signed-off-by: Loc Mai <locmai0201@gmail.com>

update changelog

6f805d3

Signed-off-by: Loc Mai <locmai0201@gmail.com>

fix the tests by setting bounds and bucket counts

7b5aa64

Signed-off-by: Loc Mai <locmai0201@gmail.com>

fix per aneurysm9's comment

1979cbf

Signed-off-by: Loc Mai <locmai0201@gmail.com>

handle delta-cumulative histogram interval misalignments

e42fcea

Signed-off-by: xchen <xchen@axon.com>

handle delta-cumulative histogram interval misalignments

504e3b5

Signed-off-by: xchen <xchen@axon.com>

add test for misalignments

98c0090

Signed-off-by: xchen <xchen@axon.com>

add code change and test to address out-of-bound error when comparing…

b2e18ca

… bucket boundaries Signed-off-by: xchen <xchen@axon.com>

Merge pull request open-telemetry#1 from hkfgo/chore/rebase-nabam-del…

c7d17bb

…ta-prom Chore/rebase nabam delta prom

github-actions bot added the exporter/prometheus label Jun 27, 2023

github-actions bot requested a review from Aneurysm9 June 27, 2023 17:30

hkfgo added 4 commits June 27, 2023 10:45

handle delta-cumulative histogram interval misalignments

3344f60

Signed-off-by: stephenchen <x.chen1016@gmail.com>

handle delta-cumulative histogram interval misalignments

a52f5af

Signed-off-by: stephenchen <x.chen1016@gmail.com>

add test for misalignments

107b53b

Signed-off-by: stephenchen <x.chen1016@gmail.com>

add code change and test to address out-of-bound error when comparing…

ca4dde2

… bucket boundaries Signed-off-by: stephenchen <x.chen1016@gmail.com>

hkfgo force-pushed the chore/rebase-nabam-delta-prom branch from b2e18ca to ca4dde2 Compare June 27, 2023 17:49

hkfgo marked this pull request as ready for review June 27, 2023 17:54

github-actions bot added the Stale label Oct 26, 2023

github-actions bot removed the Stale label Oct 27, 2023

Merge branch 'main' into chore/rebase-nabam-delta-prom

e6f0cef

github-actions bot added the Stale label Nov 17, 2023

djaglowski removed the Stale label Nov 17, 2023

atoulme reviewed Nov 29, 2023

View reviewed changes

exporter/prometheusexporter/accumulator.go Outdated Show resolved Hide resolved

atoulme reviewed Nov 29, 2023

View reviewed changes

exporter/prometheusexporter/accumulator.go Outdated Show resolved Hide resolved

atoulme reviewed Nov 29, 2023

View reviewed changes

exporter/prometheusexporter/accumulator.go Outdated Show resolved Hide resolved

atoulme reviewed Nov 29, 2023

View reviewed changes

exporter/prometheusexporter/accumulator.go Outdated Show resolved Hide resolved

hkfgo added 3 commits December 6, 2023 14:48

Merge branch 'main' into chore/rebase-nabam-delta-prom

5d6f49d

tidy up accumulator comments and logs

2c906ef

tidy up accumulator comments and logs

a52102d

atoulme approved these changes Dec 18, 2023

View reviewed changes

atoulme added the ready to merge Code review completed; ready to merge by maintainers label Dec 29, 2023

github-actions bot mentioned this pull request Jan 2, 2024

Weekly Report: 2023-12-26 - 2024-01-02 #30242

Closed

88 tasks

djaglowski merged commit aaaaa0c into open-telemetry:main Jan 8, 2024
88 checks passed

github-actions bot added this to the next release milestone Jan 8, 2024

sh0rez mentioned this pull request Jan 12, 2024

new component: deltatocumulative processor #30479

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[exporter/prometheusexporter] accumulate delta temporality histograms #23790

[exporter/prometheusexporter] accumulate delta temporality histograms #23790

hkfgo commented Jun 27, 2023 •

edited

Loading

linux-foundation-easycla bot commented Jun 27, 2023 •

edited

Loading

linux-foundation-easycla bot commented Jun 27, 2023 •

edited

Loading

github-actions bot commented Oct 26, 2023

hampusrosvall commented Oct 26, 2023

hkfgo commented Oct 26, 2023

ggreen53 commented Oct 26, 2023 •

edited

Loading

jpkrohling commented Nov 2, 2023

github-actions bot commented Nov 17, 2023

atoulme commented Nov 29, 2023

hkfgo commented Dec 6, 2023

jpkrohling commented Dec 8, 2023

hkfgo commented Dec 18, 2023

gburton1 commented Dec 28, 2023

[exporter/prometheusexporter] accumulate delta temporality histograms #23790

[exporter/prometheusexporter] accumulate delta temporality histograms #23790

Conversation

hkfgo commented Jun 27, 2023 • edited Loading

linux-foundation-easycla bot commented Jun 27, 2023 • edited Loading

linux-foundation-easycla bot commented Jun 27, 2023 • edited Loading

github-actions bot commented Oct 26, 2023

hampusrosvall commented Oct 26, 2023

hkfgo commented Oct 26, 2023

ggreen53 commented Oct 26, 2023 • edited Loading

jpkrohling commented Nov 2, 2023

github-actions bot commented Nov 17, 2023

atoulme commented Nov 29, 2023

hkfgo commented Dec 6, 2023

jpkrohling commented Dec 8, 2023

hkfgo commented Dec 18, 2023

gburton1 commented Dec 28, 2023

hkfgo commented Jun 27, 2023 •

edited

Loading

linux-foundation-easycla bot commented Jun 27, 2023 •

edited

Loading

linux-foundation-easycla bot commented Jun 27, 2023 •

edited

Loading

ggreen53 commented Oct 26, 2023 •

edited

Loading