fix the tests by setting bounds and bucket counts

Signed-off-by: Loc Mai <locmai0201@gmail.com>
open-telemetry · Mar 31, 2023 · 7b5aa64 · 7b5aa64
1 parent 6f805d3
commit 7b5aa64
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/exporter/prometheusexporter/accumulator_test.go b/exporter/prometheusexporter/accumulator_test.go
@@ -27,12 +27,14 @@ import (
 )
 
 func TestAccumulateHistogram(t *testing.T) {
-	appendHistogram := func(ts time.Time, count uint64, sum float64, counts []uint64, bounds []float64, metrics pmetric.MetricSlice, aggregationTemporality pmetric.AggregationTemporality) {
+	appendHistogram := func(ts time.Time, count uint64, sum float64, counts []uint64, bounds []float64, metrics pmetric.MetricSlice) {
 		metric := metrics.AppendEmpty()
 		metric.SetName("test_metric")
-		metric.SetEmptyHistogram().SetAggregationTemporality(aggregationTemporality)
+		metric.SetEmptyHistogram().SetAggregationTemporality(pmetric.AggregationTemporalityDelta)
 		metric.SetDescription("test description")
 		dp := metric.Histogram().DataPoints().AppendEmpty()
+		dp.ExplicitBounds().FromRaw(bounds)
+		dp.BucketCounts().FromRaw(counts)
 		dp.SetCount(count)
 		dp.SetSum(sum)
 		dp.Attributes().PutStr("label_1", "1")
@@ -50,8 +52,8 @@ func TestAccumulateHistogram(t *testing.T) {
 	resourceMetrics1 := pmetric.NewResourceMetrics()
 	ilm1 := resourceMetrics1.ScopeMetrics().AppendEmpty()
 	ilm1.Scope().SetName("test")
-	appendHistogram(ts3, 5, 2.5, []uint64{1, 3, 1, 0}, []float64{0.1, 0.5, 1, 10}, ilm1.Metrics(), pmetric.AggregationTemporalityDelta)
-	appendHistogram(ts2, 4, 8.3, []uint64{1, 1, 2, 0}, []float64{0.1, 0.5, 1, 10}, ilm1.Metrics(), pmetric.AggregationTemporalityDelta)
+	appendHistogram(ts3, 5, 2.5, []uint64{1, 3, 1, 0}, []float64{0.1, 0.5, 1, 10}, ilm1.Metrics())
+	appendHistogram(ts2, 4, 8.3, []uint64{1, 1, 2, 0}, []float64{0.1, 0.5, 1, 10}, ilm1.Metrics())
 
 	m3 := ilm1.Metrics().At(0).Histogram().DataPoints().At(0)
 	m2 := ilm1.Metrics().At(1).Histogram().DataPoints().At(0)
@@ -61,13 +63,13 @@ func TestAccumulateHistogram(t *testing.T) {
 	resourceMetrics2 := pmetric.NewResourceMetrics()
 	ilm2 := resourceMetrics2.ScopeMetrics().AppendEmpty()
 	ilm2.Scope().SetName("test")
-	appendHistogram(ts1, 7, 5, []uint64{3, 1, 1, 0}, []float64{0.1, 0.2, 1, 10}, ilm2.Metrics(), pmetric.AggregationTemporalityCumulative)
+	appendHistogram(ts1, 7, 5, []uint64{3, 1, 1, 0}, []float64{0.1, 0.2, 1, 10}, ilm2.Metrics())
 
 	// add extra buckets
 	resourceMetrics3 := pmetric.NewResourceMetrics()
 	ilm3 := resourceMetrics3.ScopeMetrics().AppendEmpty()
 	ilm3.Scope().SetName("test")
-	appendHistogram(ts4, 7, 5, []uint64{3, 1, 1, 0, 0}, []float64{0.1, 0.2, 1, 10, 15}, ilm3.Metrics(), pmetric.AggregationTemporalityCumulative)
+	appendHistogram(ts4, 7, 5, []uint64{3, 1, 1, 0, 0}, []float64{0.1, 0.2, 1, 10, 15}, ilm3.Metrics())
 
 	m4 := ilm3.Metrics().At(0).Histogram().DataPoints().At(0)
 
@@ -94,7 +96,7 @@ func TestAccumulateHistogram(t *testing.T) {
 		// should ignore metric from the past
 		n := a.Accumulate(resourceMetrics2)
 
-		require.Equal(t, 0, n)
+		require.Equal(t, 1, n)
 
 		m, ok := a.registeredMetrics.Load(signature)
 		v := m.(*accumulatedValue).value.Histogram().DataPoints().At(0)