[processor/resourcedetection] Add host.arch to system detector
#22940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal/metadataproviders
processor/resourcedetection
github-actions
bot
added
cmd/configschema
mx-psi
force-pushed
the
mx-psi/system-host-arch
branch
from
1eef781 to
dcf32f3
Compare
mx-psi
force-pushed
the
mx-psi/system-host-arch
branch
from
dcf32f3 to
cb33041
Compare
mx-psi
removed
cmd/configschema
|
Sorry for the noise, this should be ready to review |
|
Posted a Q in #22045 (comment) |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Not stale, on hold because of #21482 |
|
@dmitryax this is ready for review after #21482 has landed Also cc @omrozowicz-splunk if you want to review that I am using the new functionality correctly :) |
LGTM! |
dmitryax
approved these changes
Jul 18, 2023
|
@mx-psi Please rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add
host.archto system detector. It is detected viaruntime.GOARCH.This way of detecting may be wrong if running under an emulator or binary translator; the only common case I know of this happening in practice is on ARM64 macOS when using Rosetta. There is a way to detect this (see DataDog/gohai/pull/77) but since we provide arm64 builds for macOS, I think this is a non-issue
Link to tracking Issue: Fixes #22939
Testing: Added unit tests. Tested on my Linux AMD64 laptop
Documentation: Documented new attribute on README