This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
[platform] Detect if running under Rosetta translator #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump `golang.org/x/sys` package to latest version
hush-hush
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Detect whether running under Rosetta translator Bump `golang.org/x/sys` package to latest version * Fix merge Bump sys package
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 18, 2023
) **Description:** Add `host.arch` to system detector. It is detected via `runtime.GOARCH`. This way of detecting may be wrong if running under an emulator or binary translator; the only common case I know of this happening in practice is on ARM64 macOS when using Rosetta. There is a way to detect this (see DataDog/gohai/pull/77) but since we provide arm64 builds for macOS, I think this is a non-issue **Link to tracking Issue:** Fixes #22939 **Testing:** Added unit tests. Tested on my Linux AMD64 laptop **Documentation:** Documented new attribute on README
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
golang.org/x/syspackage versionAdditional notes
To detect whether we are running under Rosetta we follow the official Apple docs recommendation