Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass processor params to the detectors #1745

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

bogdandrutu
Copy link
Member

Fix ecs detector to not use the default golang logger.

Fixes #1645
Fixes #1586

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #1745 (15aaad9) into master (ed584a5) will increase coverage by 0.00%.
The diff coverage is 86.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1745   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files         376      376           
  Lines       18167    18168    +1     
=======================================
+ Hits        16331    16333    +2     
+ Misses       1378     1377    -1     
  Partials      458      458           
Flag Coverage Δ
integration 70.93% <ø> (ø)
unit 88.59% <86.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...resourcedetectionprocessor/internal/aws/ec2/ec2.go 91.66% <ø> (ø)
.../internal/aws/elasticbeanstalk/elasticbeanstalk.go 100.00% <ø> (ø)
...sor/resourcedetectionprocessor/internal/env/env.go 100.00% <ø> (ø)
...resourcedetectionprocessor/internal/gcp/gce/gce.go 100.00% <ø> (ø)
...sourcedetectionprocessor/internal/system/system.go 100.00% <ø> (ø)
...etectionprocessor/internal/aws/ecs/metadata_ecs.go 69.23% <60.00%> (ø)
processor/resourcedetectionprocessor/factory.go 98.68% <100.00%> (ø)
...resourcedetectionprocessor/internal/aws/ecs/ecs.go 85.24% <100.00%> (ø)
...cedetectionprocessor/internal/resourcedetection.go 97.05% <100.00%> (+0.04%) ⬆️
processor/groupbytraceprocessor/event.go 96.77% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed584a5...15aaad9. Read the comment docs.

Fix ecs detector to not use the default golang logger.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 471b7c6 into open-telemetry:master Dec 3, 2020
@bogdandrutu bogdandrutu deleted the logzap branch December 3, 2020 02:04
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants