Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/resourcedetection] ecs detector uses log package instead of zap #1586

Closed
jrcamp opened this issue Nov 13, 2020 · 1 comment · Fixed by #1745
Closed

[processor/resourcedetection] ecs detector uses log package instead of zap #1586

jrcamp opened this issue Nov 13, 2020 · 1 comment · Fixed by #1745
Assignees
@anuraaga

Comments

@jrcamp
Copy link
Contributor

jrcamp commented Nov 13, 2020 •
edited
Loading

ecs detector is using Go log package instead of zap.

opentelemetry-collector-contrib/processor/resourcedetectionprocessor/internal/aws/ecs/metadata_ecs.go

Line 77 in 22f0f30

log.Printf("Received error constructing request to ECS Task Metadata Endpoint: %v", err)

see #1585 (comment)_
@jrcamp
Copy link
Contributor Author

jrcamp commented Nov 13, 2020

Originally added in #1360 by @willarmiros

@willarmiros willarmiros mentioned this issue Nov 19, 2020
Closed
@bogdandrutu bogdandrutu mentioned this issue Dec 2, 2020
Merged
dyladan referenced this issue in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@bogdandrutu
Fix make list test commands to not inlude the last line (#1586)
379b68c 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
ljmsc referenced this issue in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
@MadVikingGod @royvandewater
Add HTTP/JSON to the otlp exporter (#1586)
7153ef2 
* Add HTTP/JSON to the otlp exporter

Co-Authored-By: Roy van de Water <72016+royvandewater@users.noreply.github.com>

* PR fixup

Co-authored-by: Roy van de Water <72016+royvandewater@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anuraaga anuraaga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass processor params to the detectors bogdandrutu/opentelemetry-collector-contrib
2 participants
@jrcamp @anuraaga