Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/batchperresourceattr] Add CODEOWNERS #15371

Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 21, 2022

Description:

Add CODEOWNERS for pkg/batchperresourceattr.
I chose these CODEOWNERS based on the known importers of the module.

Link to tracking Issue: Updates #3870

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 21, 2022
@mx-psi mx-psi requested review from atoulme, owais, dmitryax and a team October 21, 2022 10:06
@mx-psi mx-psi requested a review from pmcollins October 21, 2022 10:06
.github/CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
@mx-psi mx-psi requested a review from dmitryax October 21, 2022 16:01
@mx-psi
Copy link
Member Author

mx-psi commented Oct 24, 2022

@pmcollins would love to have your approval before merging this :)

@bogdandrutu
Copy link
Member

@mx-psi @pmcollins is not that active anymore in this repo :) I know from some internal sources :))

@mx-psi
Copy link
Member Author

mx-psi commented Oct 26, 2022

@mx-psi @pmcollins is not that active anymore in this repo :) I know from some internal sources :))

That makes me then the only Pablo now contributing to the Collector I think 😄

@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Oct 26, 2022
@pmcollins
Copy link
Member

Not sure where all of this is coming from 😆. I do have this PR out: #15233. BTW if you're reading this, reviews are appreciated 🙂.

@mx-psi
Copy link
Member Author

mx-psi commented Oct 26, 2022

Not sure where all of this is coming from laughing. I do have this PR out: #15233. BTW if you're reading this, reviews are appreciated slightly_smiling_face.

Oh okay, I haven't gotten around to checking that out yet, didn't realize it was your PR :)

Would you want to be a CODEOWNER for this module then?

@pmcollins
Copy link
Member

Not sure where all of this is coming from laughing. I do have this PR out: #15233. BTW if you're reading this, reviews are appreciated slightly_smiling_face.

Oh okay, I haven't gotten around to checking that out yet, didn't realize it was your PR :)

Would you want to be a CODEOWNER for this module then?

Oh, no, thank you -- I'm not familiar with it. Just wanted to chime in and say that I'm still around (but, as Bogdan suggests, working on other things, too :)

@mx-psi mx-psi merged commit f65fc7c into open-telemetry:main Oct 26, 2022
@mx-psi mx-psi deleted the mx-psi/add-codeowner-batchperresourceattr branch October 26, 2022 16:06
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
* [pkg/batchperresourceattr] Add CODEOWNERS

* Apply suggestions from code review

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>

* Remove @pmcollins from owners

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants