Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to generate cfgschema yaml files #15233

Merged
merged 11 commits into from
Dec 5, 2022
Merged

Add command to generate cfgschema yaml files #15233

merged 11 commits into from
Dec 5, 2022

Conversation

pmcollins
Copy link
Member

Description: Creates a simple CLI to generate config schema yaml files (or a zip archive).

Link to tracking Issue: #15231

Testing: Tested locally and unit tested.

Documentation: Readme added

@pmcollins pmcollins changed the title Add basic yamlgen functionality Add command to generate cfgschema yaml files Oct 24, 2022
@pmcollins pmcollins marked this pull request as ready for review October 25, 2022 14:08
@pmcollins pmcollins requested a review from a team October 25, 2022 14:08
@pmcollins
Copy link
Member Author

Failing check appears to be unrelated to this change.

Copy link
Contributor

@hughesjj hughesjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me but I had some minor questions I'd like address/education on before I give my approval.

I'm 90% sure the interfaces are non-problematic/two way doors because we're in the same "package" and we're not exporting them anyway. If so feel free to ship as is. Sorry for being a golang noob.

cmd/configschema/fields.go Outdated Show resolved Hide resolved
cmd/configschema/yamlgen/yamlgen/zip_writer.go Outdated Show resolved Hide resolved
cmd/configschema/yamlgen/yamlgen/file_yaml_writer.go Outdated Show resolved Hide resolved
cmd/configschema/yamlgen/yamlgen/file_yaml_writer.go Outdated Show resolved Hide resolved
.chloggen/yamlgen.yaml Show resolved Hide resolved
@pmcollins
Copy link
Member Author

Also, check out this issue, which I had been unable to find previously, but just went stale, so I was notified about it #5006

@dmitryax
Copy link
Member

dmitryax commented Nov 4, 2022

Also, check out this issue, which I had been unable to find previously, but just went stale, so I was notified about it #5006

Do we track generation of human readable yamls in a separate issue? Will you have a chance to work on that later?

cmd/configschema/cfgmetadatagen/cfgmetadatagen/cli.go Outdated Show resolved Hide resolved
cmd/configschema/fields.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the cmd/configschema configschema command label Nov 11, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 26, 2022
@dmitryax dmitryax removed the Stale label Dec 5, 2022
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax
Copy link
Member

dmitryax commented Dec 5, 2022

@pmcollins please rebase and we can merge it

@runforesight
Copy link

runforesight bot commented Dec 5, 2022

Foresight Summary

    
Major Impacts

build-and-test-windows duration(4 seconds) has decreased 33 minutes 36 seconds compared to main branch avg(33 minutes 40 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 4 seconds (33 minutes 36 seconds less than main branch avg.) and finished at 5th Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 54 seconds (1 minute 49 seconds less than main branch avg.) and finished at 5th Dec, 2022.


Job Failed Steps Tests
publish-latest -     🔗  N/A See Details
build-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 21 seconds (58 seconds less than main branch avg.) and finished at 5th Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 21 seconds (2 minutes 48 seconds less than main branch avg.) and finished at 5th Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  build-and-test workflow has finished in 39 minutes 51 seconds (16 minutes 29 seconds less than main branch avg.) and finished at 5th Dec, 2022.


Job Failed Steps Tests
unittest-matrix (1.19, internal) -     🔗  ✅ 591  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1466  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 0  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) -     🔗  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) -     🔗  ✅ 1466  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 0  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2532  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) -     🔗  ✅ 2533  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2412  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4355  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 1845  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1845  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 4345  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) -     🔗  ✅ 2412  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 59  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
checks -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  load-tests workflow has finished in 7 minutes 59 seconds (6 minutes 54 seconds less than main branch avg.) and finished at 5th Dec, 2022.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 13 minutes 7 seconds (⚠️ 4 minutes 47 seconds more than main branch avg.) and finished at 5th Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants