Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/mongodbreceiver] Partial error fix #13109

Merged
merged 6 commits into from
Aug 9, 2022
Merged

[receiver/mongodbreceiver] Partial error fix #13109

merged 6 commits into from
Aug 9, 2022

Conversation

JonathanWamsley
Copy link
Contributor

@JonathanWamsley JonathanWamsley commented Aug 8, 2022 •
edited
Loading

Description:

  • fixes issues where partial errors are not recorded due to passing the ScrapeErrors struct without a pointer
  • rename errors/scraperErrors to errs to avoid possible shadowing of the errors package

Link to tracking Issue:
#13108

@JonathanWamsley JonathanWamsley force-pushed the mongodbreceiver-scrape-error-fix branch from f99da17 to 8e8309d Compare August 9, 2022 13:11
@JonathanWamsley JonathanWamsley marked this pull request as ready for review August 9, 2022 15:22
@JonathanWamsley JonathanWamsley requested a review from a team August 9, 2022 15:22
djaglowski
djaglowski reviewed Aug 9, 2022
View reviewed changes
receiver/mongodbreceiver/README.md Outdated Show resolved Hide resolved
receiver/mongodbreceiver/testdata/integration/expected.3_0.json Outdated Show resolved Hide resolved
receiver/mongodbreceiver/metrics.go Outdated Show resolved Hide resolved
receiver/mongodbreceiver/scraper_test.go Outdated Show resolved Hide resolved
@JonathanWamsley JonathanWamsley force-pushed the mongodbreceiver-scrape-error-fix branch from 8e8309d to 5261163 Compare August 9, 2022 19:11
@djaglowski djaglowski merged commit 10ed2c5 into open-telemetry:main Aug 9, 2022
This was referenced Aug 9, 2022
Closed
Closed
@JonathanWamsley JonathanWamsley deleted the mongodbreceiver-scrape-error-fix branch August 10, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

Assignees

@djaglowski djaglowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanWamsley @djaglowski