You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Partial errors are being recorded in integration tests when they don't have to be. Before metrics are recorded, the mongodb version and storage engine should be checked instead of emitting a partial error.
Steps to reproduce
Run integration test and check for partial errors before scrape returns.
At the end of scrape, running an integration test like 5.0 I would expect no partial errors.
What did you expect to see?
Expect no partial errors when running integration tests.
What did you see instead?
For mongodb integration test 5
Error Amount:scrapererror.PartialScrapeError{error:(*multierr.multiError)(0xc0000b4420), Failed:4}
Errors: "could not find key for metric; could not find key for metric; could not find key for metric; could not find key for metric"
What version did you use?
on main, mongodb version 2.6, 3, 4 and 5
Additional context
These partial errors got passed silently and were fixed recently from #13109 . These partial errors will stop reporting with the correct version and storage engine checks which will be documented in the readme.
The text was updated successfully, but these errors were encountered:
Describe the bug
Partial errors are being recorded in integration tests when they don't have to be. Before metrics are recorded, the mongodb version and storage engine should be checked instead of emitting a partial error.
Steps to reproduce
Run integration test and check for partial errors before scrape returns.
At the end of scrape, running an integration test like 5.0 I would expect no partial errors.
What did you expect to see?
Expect no partial errors when running integration tests.
What did you see instead?
For mongodb integration test 5
What version did you use?
on main, mongodb version 2.6, 3, 4 and 5
Additional context
These partial errors got passed silently and were fixed recently from #13109 . These partial errors will stop reporting with the correct version and storage engine checks which will be documented in the readme.
The text was updated successfully, but these errors were encountered: