-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
receiver/azureblobreceiver First PR #11872
receiver/azureblobreceiver First PR #11872
Conversation
…y-collector-contrib into eedorenko/azureblobreceiver-1
…y-collector-contrib into eedorenko/azureblobreceiver-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmm-sumo please review
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
pmm-sumo is no longer involved in the project. @mx-psi as the next sponsor on the list, please review this component. |
Removing pmm-sumo, moving @Aneurysm9 and @mx-psi to the bottom of the rotation after sponsoring: open-telemetry#11872 open-telemetry#11871
Removing pmm-sumo, moving @Aneurysm9 and @mx-psi to the bottom of the rotation after sponsoring: #11872 #11871
…dorenko/opentelemetry-collector-contrib into eedorenko/azureblobreceiver-1
…y-collector-contrib into eedorenko/azureblobreceiver-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few more comments
…y-collector-contrib into eedorenko/azureblobreceiver-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"go.opentelemetry.io/collector/config" | ||
) | ||
|
||
type Config struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open a follow up PR to document the fields directly in the Go struct? This is not urgent, but will be useful in the future for automatic configuration schema generation
You need to add this component to
|
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
…dorenko/opentelemetry-collector-contrib into eedorenko/azureblobreceiver-1
Looks good, will merge once all tests pass (probably tomorrow morning first thing if nobody else has done it :)) |
Description:
azureblobreceiver reads logs and traces from Azure Blob Storage.
Fixes #8834
Documentation:
Readme describing receiver functionality and configuration.