Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/azureblobexporter First PR #11871

Closed

Conversation

eedorenko
Copy link
Contributor

Description:
azureblobexporter exports logs and traces to Azure Blob Storage

Fixes #8823

Documentation:
Readme describing exporter functionality and configuration.

@eedorenko eedorenko requested review from a team and pmm-sumo July 1, 2022 18:03
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmm-sumo please review

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 26, 2022
@codeboten
Copy link
Contributor

pmm-sumo is not longer involved in the project. @Aneurysm9 as the next name on the sponsors list, please review this component.

codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this pull request Jul 27, 2022
Removing pmm-sumo, moving @Aneurysm9 and @mx-psi to the bottom of the rotation after sponsoring: open-telemetry#11872 open-telemetry#11871
@github-actions github-actions bot removed the Stale label Jul 28, 2022
bogdandrutu pushed a commit that referenced this pull request Aug 1, 2022
Removing pmm-sumo, moving @Aneurysm9 and @mx-psi to the bottom of the rotation after sponsoring: #11872 #11871
@jpkrohling
Copy link
Member

ping @Aneurysm9

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to add your component to github issues dropdowns. See #16603 for reference.

exporter/azureblobexporter/factory.go Outdated Show resolved Hide resolved
exporter/azureblobexporter/factory.go Outdated Show resolved Hide resolved
exporter/azureblobexporter/go.mod Outdated Show resolved Hide resolved
eedorenko and others added 2 commits December 21, 2022 14:25
Co-authored-by: Antoine Toulme <antoine@toulme.name>
Co-authored-by: Antoine Toulme <antoine@toulme.name>
@runforesight
Copy link

runforesight bot commented Dec 21, 2022

Foresight Summary

    
Major Impacts

build-and-test-windows duration(4 seconds) has decreased 40 minutes 16 seconds compared to main branch avg(40 minutes 20 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 4 seconds (46 minutes 36 seconds less than main branch avg.) and finished at 7th Jan, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 6 seconds (2 minutes 3 seconds less than main branch avg.) and finished at 7th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 19 seconds (1 minute 28 seconds less than main branch avg.) and finished at 7th Jan, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 3 seconds (6 minutes 35 seconds less than main branch avg.) and finished at 7th Jan, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 12 minutes 28 seconds (⚠️ 3 minutes 22 seconds more than main branch avg.) and finished at 7th Jan, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 21 minutes 5 seconds (⚠️ 4 minutes 45 seconds more than main branch avg.) and finished at 7th Jan, 2023.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

❌  build-and-test workflow has finished in 8 minutes 54 seconds (43 minutes 55 seconds less than main branch avg.) and finished at 1st Feb, 2023. 2 jobs failed.


Job Failed Steps Tests
check-collector-module-version Check Collector Module Version     🔗  N/A See Details
checks Components dropdown in issue templates     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@eedorenko eedorenko requested review from atoulme and removed request for pmm-sumo December 21, 2022 23:37
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, one nit.

eedorenko and others added 2 commits January 6, 2023 16:36
Co-authored-by: Antoine Toulme <antoine@toulme.name>
@jpkrohling
Copy link
Member

@Aneurysm9, could you please review this PR?

Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, looks like I had reviewed most of this and then <squirrel!>...

This looks fine modulo the collector module versions that need to be updated.

Comment on lines +6 to +8
go.opentelemetry.io/collector v0.68.0
go.opentelemetry.io/collector/component v0.68.0
go.opentelemetry.io/collector/pdata v1.0.0-rc2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will need to be updated to require current versions.

@mlavrent
Copy link

mlavrent commented Apr 24, 2023

Hey, wanted to check if there was any progress on this? Looking to use this :). Happy to contribute something if there's still work to be done and the author (@eedorenko) is no longer involved. Let me know!

Is the only required change to update the go.mod to current versions @Aneurysm9 ?

@atoulme atoulme added the Accepted Component New component has been sponsored label May 19, 2023
@atoulme
Copy link
Contributor

atoulme commented May 19, 2023

Please rebase.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 3, 2023
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New component: Azure Blob Exporter
8 participants