Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all codeowners are members of the OpenTelemetry organization #20868

Closed
40 tasks done
atoulme opened this issue Apr 12, 2023 · 14 comments
Closed
40 tasks done

Ensure that all codeowners are members of the OpenTelemetry organization #20868

atoulme opened this issue Apr 12, 2023 · 14 comments
Labels
discussion needed Community discussion needed

Comments

@atoulme
Copy link
Contributor

atoulme commented Apr 12, 2023 •
edited
Loading

Component(s)

No response

Describe the issue you're reporting

Not all codeowners of this repository are members of the OpenTelemetry github organization, which membership is associated with membership of the OpenTelemetry project.

The guidelines enforce membership because it allows to assign and ping codeowners on issues or pull requests. Unfortunately, if you try to create an issue or assign a PR to a codeowner who is not member of OpenTelemetry, the workflow fails. I would like to fix this issue.

Going forward, I would also ideally like to make sure that we check that codeowners are members of the github organization whenever the codeowners file is touched.

The process to become a member of OpenTelemetry is straightforward. Open this issue template on the community project to get started.

I have identified a list of codeowners who are not currently members of OpenTelemetry. I will ping them in this issue below.

  1. Please cross your name to indicate you have seen this message.
  2. (optional) Please get in touch over Slack: I have created a slack channel for the purpose of codeowner discussions, #otel-collector-codeowners. Feel free to reply here as well and provide clarifications if any information is incorrect.
  3. Please work towards membership. Feel free to use 2. for any questions.
  4. If I don't hear from you in the next 60 days (tentative), I will regrettably need to open a pull request to remove you from the codeowners.

Thank you and apologies for the inconvenience.
@atoulme atoulme added the discussion needed Community discussion needed label Apr 12, 2023
@AbhiPrasad AbhiPrasad mentioned this issue Apr 12, 2023
Closed
6 tasks
@mx-psi mx-psi pinned this issue Apr 12, 2023
@oppegard oppegard mentioned this issue Apr 12, 2023
Closed
6 tasks
@chrroberts-pure chrroberts-pure mentioned this issue Apr 12, 2023
Closed
6 tasks
@bertysentry bertysentry mentioned this issue Apr 12, 2023
Closed
6 tasks
@codeboten codeboten mentioned this issue Apr 12, 2023
Merged
@varunraiko varunraiko mentioned this issue Apr 13, 2023
Closed
6 tasks
@mx-psi mx-psi mentioned this issue Apr 13, 2023
Merged
@jkowall jkowall mentioned this issue Apr 14, 2023
Closed
@jacobmarble jacobmarble mentioned this issue Apr 19, 2023
Closed
6 tasks
@jacobmarble
Copy link
Contributor

Please cross your name to indicate you have seen this message

I don't have edit privileges, but you may cross me off with this PR open-telemetry/community#1446

@dgoscn dgoscn mentioned this issue Apr 21, 2023
Closed
6 tasks
@TylerHelmuth TylerHelmuth mentioned this issue Apr 26, 2023
Merged
@yotamloe yotamloe mentioned this issue May 9, 2023
Closed
6 tasks
This was referenced May 10, 2023
Merged
Closed
@mx-psi mx-psi mentioned this issue May 22, 2023
Closed
@atoulme atoulme mentioned this issue May 26, 2023
Merged
@kongluoxing kongluoxing mentioned this issue Jun 5, 2023
Closed
6 tasks
@atoulme
Copy link
Contributor Author

atoulme commented Jun 15, 2023

We are now at the 60 days mark. I have checked that folks who have not checked back in have not otherwise obtained membership. I will work to check if the codeowners are still listed in the repository.

@atoulme
Copy link
Contributor Author

atoulme commented Jun 15, 2023

I have checked and all codeowners, with the exception of @ofirshmuel, are still listed as active codeowners.

This was referenced Jun 15, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 15, 2023
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 16, 2023
Closed
Closed
@djaglowski djaglowski mentioned this issue Jun 27, 2023
Merged
@yiyang5055 yiyang5055 mentioned this issue Jun 28, 2023
Closed
6 tasks
@mx-psi
Copy link
Member

mx-psi commented Jul 18, 2023

Should we unpin this now that we have sub-issues for each component?

@TylerHelmuth
Copy link
Member

Sure

@mx-psi mx-psi unpinned this issue Jul 18, 2023
@dao-jun dao-jun mentioned this issue Jul 21, 2023
Merged
@atoulme atoulme mentioned this issue Jul 21, 2023
Closed
2 tasks
djaglowski added a commit that referenced this issue Jul 26, 2023
@djaglowski
[chore] Add "Code Owners" field to new component template (#23780)
635ec0b 
#20868 represents a push to ensure that all component code owners are
members of the OpenTelemetry organization.

This has direct implications for our notion of "vendor-specific
components", which are those that interact specifically with a
particular vendor, and are contributed and maintained by a
representative of a vendor. We require that the vendor representative
must maintain the component, which essentially means they must be a code
owner. Therefore, I am proposing that the representative must be a
member of the org before the component may be accepted.
@ag-ramachandran ag-ramachandran mentioned this issue Jul 26, 2023
Closed
@pxaws
Copy link
Contributor

pxaws commented Jul 26, 2023

open-telemetry/community#1612

@pcwiese
Copy link
Contributor

pcwiese commented Jul 30, 2023

I've been dragging my feet on this request. Could I get a couple of sponsors so I can complete my membership request? Most of my contributions are for the azuremonitorexporter and tailsampling processor.

@atoulme
Copy link
Contributor Author

atoulme commented Jul 30, 2023

You can count on my sponsorship.

@TylerHelmuth
Copy link
Member

I'll sponsor

@alexvanboxel
Copy link
Contributor

I want to pick up my work again on the GooglePubsub receiver/exporter... I've been away for a while. But I need two persons to sponsor me toward membership. I'll mentioning some of the people I interacted it during the year(s): @mx-psi , @jrcamp , @djaglowski , @jpkrohling

My contributions are in general small, so I won't be mad if anyone don't remember me. But could someone sponsor me for membership? Thanks.

@djaglowski
Copy link
Member

@alexvanboxel, I'm happy to sponsor you.

@jpkrohling
Copy link
Member

I can sponsor you as well.

@alexvanboxel
Copy link
Contributor

Thanks @jpkrohling and @djaglowski . I will work through all the documentation over the weekend to start the procedure.

This was referenced Aug 23, 2023
Merged
Closed
@alexvanboxel alexvanboxel mentioned this issue Sep 15, 2023
Closed
6 tasks
@atoulme
Copy link
Contributor Author

atoulme commented Jan 15, 2024

Closing as the end of this campaign. A new campaign should start for the new set of codeowners who are in allowlist.

@atoulme atoulme closed this as completed Jan 15, 2024
@atoulme atoulme mentioned this issue Jan 15, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion needed Community discussion needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@jpkrohling @atoulme @jacobmarble @alexvanboxel @djaglowski @mx-psi @TylerHelmuth @pcwiese @pxaws