Demo app cart #518
Merged
Demo app cart #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
reviewed
Aug 8, 2024
Comment on lines
91
to
111
| DropdownMenuItem( | ||
| text = { | ||
| Row( | ||
| verticalAlignment = Alignment.CenterVertically | ||
| ) { | ||
| if (i == selectedQuantity) { | ||
| Icon( | ||
| imageVector = Icons.Filled.Check, | ||
| contentDescription = "Selected", | ||
| tint = Color.Black, | ||
| modifier = Modifier.size(18.dp) | ||
| ) | ||
| Spacer(modifier = Modifier.width(8.dp)) | ||
| } | ||
| Text( | ||
| text = i.toString(), | ||
| ) | ||
| } | ||
| }, | ||
| onClick = { onQuantitySelected(i) } | ||
| ) |
There was a problem hiding this comment.
I like that this was broken out into its own file. I think @LikeTheSalad had a comment previously about indent levels, and there's still some room to improve this. If you make a new topmost item called something like QuantityDropDownItem (whose constructor takes i and a boolean isSelected) then you can basically move this whole block into that new composable and save 1 or 2 indent levels. The for loop then looks something like
for (i in 1..10) {
QuantityDropDownItem(i, i == selectedQuantity)
}
breedx-splk
approved these changes
Aug 8, 2024
… added to cart - range from 1 to 10, like on the otel demo astronomy shop website.
…it should be in the center?), split up QuantityChooser into a few composables.
…price isn't being updated
…n CartScreen makes the screen respond to Empty Cart button right away and i don't know how to achieve this otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding product of specified quantity to cart and emptying cart works. QuantityChooser component moved to a separate file.