QuantityDropDownItem as a separated composable

open-telemetry · Aug 9, 2024 · 352bddb · 352bddb
1 parent c4efd94
commit 352bddb
Showing 1 changed file with 31 additions and 21 deletions.
diff --git a/demo-app/src/main/java/io/opentelemetry/android/demo/ui/shop/components/QuantityChooser.kt b/demo-app/src/main/java/io/opentelemetry/android/demo/ui/shop/components/QuantityChooser.kt
@@ -88,27 +88,37 @@ fun QuantityDropdown(
         onDismissRequest = onDismissRequest
     ) {
         for (i in 1..10) {
-            DropdownMenuItem(
-                text = {
-                    Row(
-                        verticalAlignment = Alignment.CenterVertically
-                    ) {
-                        if (i == selectedQuantity) {
-                            Icon(
-                                imageVector = Icons.Filled.Check,
-                                contentDescription = "Selected",
-                                tint = Color.Black,
-                                modifier = Modifier.size(18.dp)
-                            )
-                            Spacer(modifier = Modifier.width(8.dp))
-                        }
-                        Text(
-                            text = i.toString(),
-                        )
-                    }
-                },
-                onClick = { onQuantitySelected(i) }
-            )
+            QuantityDropDownItem(i, i == selectedQuantity, onClick = {onQuantitySelected(i)})
         }
     }
 }
+
+@Composable
+fun QuantityDropDownItem(
+    quantity: Int,
+    isSelected: Boolean,
+    onClick: () -> Unit
+){
+    DropdownMenuItem(
+        text = {
+            Row(
+                verticalAlignment = Alignment.CenterVertically
+            ) {
+                if (isSelected) {
+                    Icon(
+                        imageVector = Icons.Filled.Check,
+                        contentDescription = "Selected",
+                        tint = Color.Black,
+                        modifier = Modifier.size(18.dp)
+                    )
+                    Spacer(modifier = Modifier.width(8.dp))
+                }
+                Text(
+                    text = quantity.toString(),
+                )
+            }
+        },
+        onClick = onClick
+    )
+
+}