This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polish trace/api.md #36
polish trace/api.md #36
Changes from 2 commits
97f83ba
0c1a0c2
d4be202
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open-telemetry/opentelemetry-specification#1068
spec 在 ga 后会删除该部分。因为他们自己也没说清为什么 分析工具会产生错误。你现在这个翻译比我之前好很多
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,没看懂他们想表达什么意思
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我的理解是这样的
分析工具 catch 了到了一个我问题,他应当返回 Ok,而不是 throw 一个 404 出来。
换个不太恰当的比方
User -> App -> DB
DB 扔了一个 404,对 App 来说 应该是 200, 而不是继续 404