This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
polish trace/api.md #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlowingRuby
requested review from
addname,
sunface and
tensorchen
as code owners
wph95
suggested changes
Jan 9, 2021
Co-authored-by: JustWPH <WPH95@users.noreply.github.com>
wph95
approved these changes
Jan 9, 2021
wph95
reviewed
Jan 9, 2021
|
|
||
| 软件开发者或操作者可以设置状态码为 `Ok` 。 | ||
|
|
||
| 分析工具应当对 `Ok` 状态做出响应，抑制它们因其他原因产生的任何错误。例如，为了抑制诸如 404s 错误。 | ||
| 分析工具应当通过抑制它们因其他原因产生的错误来响应 `Ok` 状态。例如抑制嘈杂的404错误。 |
There was a problem hiding this comment.
open-telemetry/opentelemetry-specification#1068
spec 在 ga 后会删除该部分。因为他们自己也没说清为什么 分析工具会产生错误。你现在这个翻译比我之前好很多
There was a problem hiding this comment.
我的理解是这样的
分析工具 catch 了到了一个我问题，他应当返回 Ok，而不是 throw 一个 404 出来。
换个不太恰当的比方
User -> App -> DB
DB 扔了一个 404，对 App 来说 应该是 200, 而不是继续 404
sunface
approved these changes
Jan 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.