Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded build patch from test script #1938

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

iyanmv
Copy link
Member

@iyanmv iyanmv commented Sep 26, 2024

If a user has passed a custom build path to cmake, and then calls for example ninja -C <custom_build_path> run_tests, the script test_acvp_vectors.py fails due to having "build" harcoded in the calls.

Instead, let's use helpers.get_current_build_dir_name() to get the build path and use that instead. This is already done in other scripts (e.g., test_binary.py)

Fixes #1937

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

If a user has passed a custom build path to cmake, and then calls for
example `ninja -C <custom_build_path> run_tests`, the script
test_acvp_vectors.py fails due to having "build" harcoded in the calls.

Instead, let's use `helpers.get_current_build_dir_name()` to get the build
path and use that instead. This is already done in other scripts (e.g.,
test_binary.py)

Signed-off-by: Iyán Méndez Veiga <me@iyanmv.com>
@iyanmv iyanmv requested a review from dstebila as a code owner September 26, 2024 19:55
@dstebila dstebila added this to the 0.12.0 milestone Sep 26, 2024
@dstebila
Copy link
Member

Thanks for the fix!

We're about to make a release of liboqs 0.11.0 from the main branch, so let's hold off on merging this until then.

@SWilson4
Copy link
Member

LGTM as well, but since my approval will enable merge I will hold off on approving until after the release. Thanks very much for the contribution, @iyanmv.

@SWilson4 SWilson4 merged commit a552876 into open-quantum-safe:main Sep 27, 2024
71 checks passed
@iyanmv iyanmv deleted the fix-test-acvp-vectors branch September 27, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tests in test_acvp_vectors.py fail when using custom build path
3 participants