Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release broke (again) tests when not using default build directory #2018

Closed
iyanmv opened this issue Dec 12, 2024 · 3 comments · Fixed by #2019
Closed

New release broke (again) tests when not using default build directory #2018

iyanmv opened this issue Dec 12, 2024 · 3 comments · Fixed by #2019

Comments

@iyanmv
Copy link
Member

iyanmv commented Dec 12, 2024

Describe the bug
Exactly the same issue as described in #1937, that was fixed with #1938

This time the new issue affects all the new tests added to test_acvp_vectors.py by #1919

I will provide a new patch to fix this issue on the new tests soon.

Would it be possible to modify the CI pipeline to build on a custom path to detect this kind of error before merging? What do you think?

iyanmv added a commit to iyanmv/liboqs that referenced this issue Dec 12, 2024
This fixes open-quantum-safe#2018 using `helpers.get_current_build_dir_name()`

Signed-off-by: Iyán Méndez Veiga <me@iyanmv.com>
@SWilson4
Copy link
Member

Would it be possible to modify the CI pipeline to build on a custom path to detect this kind of error before merging? What do you think?

I think it would be nice to have—would you be willing to take a stab at adding it in #2019?

@iyanmv
Copy link
Member Author

iyanmv commented Dec 12, 2024

I think it would be nice to have—would you be willing to take a stab at adding it in #2019?

Alright, let me have a look.

@baentsch
Copy link
Member

Thanks for bringing this (again) up @iyanmv -- and of course for fixing it! Reminds me of open-quantum-safe/oqs-provider#545: CI along the whole chain (software and releases) could benefit from some further attention/improvement... Tagging @praveksharma as a heads-up for the next oqsprovider release.

SWilson4 pushed a commit that referenced this issue Dec 13, 2024
…om path (#2019)

* Remove hardcoded build paths

This fixes #2018 using `helpers.get_current_build_dir_name()`

Signed-off-by: Iyán Méndez Veiga <me@iyanmv.com>

* Use a random build path in the basic build test

Signed-off-by: Iyán Méndez Veiga <me@iyanmv.com>

---------

Signed-off-by: Iyán Méndez Veiga <me@iyanmv.com>
@github-project-automation github-project-automation bot moved this from Todo to Done in liboqs planning Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants