-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release broke (again) tests when not using default build directory #2018
Comments
This fixes open-quantum-safe#2018 using `helpers.get_current_build_dir_name()` Signed-off-by: Iyán Méndez Veiga <me@iyanmv.com>
I think it would be nice to have—would you be willing to take a stab at adding it in #2019? |
Alright, let me have a look. |
Thanks for bringing this (again) up @iyanmv -- and of course for fixing it! Reminds me of open-quantum-safe/oqs-provider#545: CI along the whole chain (software and releases) could benefit from some further attention/improvement... Tagging @praveksharma as a heads-up for the next |
…om path (#2019) * Remove hardcoded build paths This fixes #2018 using `helpers.get_current_build_dir_name()` Signed-off-by: Iyán Méndez Veiga <me@iyanmv.com> * Use a random build path in the basic build test Signed-off-by: Iyán Méndez Veiga <me@iyanmv.com> --------- Signed-off-by: Iyán Méndez Veiga <me@iyanmv.com>
Describe the bug
Exactly the same issue as described in #1937, that was fixed with #1938
This time the new issue affects all the new tests added to
test_acvp_vectors.py
by #1919I will provide a new patch to fix this issue on the new tests soon.
Would it be possible to modify the CI pipeline to build on a custom path to detect this kind of error before merging? What do you think?
The text was updated successfully, but these errors were encountered: