Skip to content
This repository has been archived by the owner on Apr 8, 2023. It is now read-only.

LizardmanShamanPlugin: Rewrite #2175

Merged
merged 1 commit into from
Jan 2, 2020
Merged

LizardmanShamanPlugin: Rewrite #2175

merged 1 commit into from
Jan 2, 2020

Conversation

rdutta
Copy link
Contributor

@rdutta rdutta commented Dec 30, 2019

Addresses #2174

  • Removes Notifier feature as the in-game message no longer exists (I believe)
  • Removes the pie overlay timer (which is pretty useless)
  • Draws an overlay for Spawn walkable/explosion tiles (more useful)

@rdutta rdutta changed the title Re-write lizardmanshaman plugin Rewrite lizardmanshaman plugin Dec 30, 2019
@rdutta rdutta changed the title Rewrite lizardmanshaman plugin LizardmanShamanPlugin: Rewrite Dec 30, 2019
@Owain94
Copy link
Contributor

Owain94 commented Dec 30, 2019

You should put yourself in the licensing header instead of openosrs if it’s your code

If parts are from the removed files just add yourself in addition to openosrs

@f0rmatme
Copy link
Contributor

I always thought this plugin needed a rewrite.
Nice job

Copy link
Contributor

@Ganom Ganom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a checkstyle file you can import to intellij that will fix most of these code style issues, I highly recommend doing that, then using the reformat code right click option in intellij.

@rdutta
Copy link
Contributor Author

rdutta commented Dec 30, 2019

There is a checkstyle file you can import to intellij that will fix most of these code style issues, I highly recommend doing that, then using the reformat code right click option in intellij.

Imported the checkstyle and made the suggested changes.

Added name to licensing header.

@rdutta rdutta requested a review from Ganom December 31, 2019 00:02
@xKylee xKylee merged commit f93ed47 into open-osrs:master Jan 2, 2020
@rdutta rdutta mentioned this pull request Jan 3, 2020
@Owain94 Owain94 added the enhancement New feature or request label Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants