Check API Compatibility #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
…ry#3410) * disallow renaming metrics using the prometheus receiver * add TODO for removing the validation
* Create snyk-container-analysis.yml * Create snyk-container-analysis.yml * Renamed occurrences of Application to Collector - Changed references in function/method docs from 'application' to 'collector server' - Changed instance variable names from (app *Application) to (col *Collector) * Rename more instances of Application to Collector - renamed files in service/application* to service/collector* - replaced occurrences of app to col * Renamed references of service.Application to collector (or collector server) * Added change log entry stub * Added number of PR * Fixed merge conflicts * Update CHANGELOG.md * Renamed ColSettings to CollectorSettings * Fixed naming error * Delete snyk-container-analysis.yml * Moved change log entry unreleased section From v0.28.0-beta to unreleased (breaking change) * Deleted extra new line in change log * Renamed occurrences of Application to Collector - Changed references in function/method docs from 'application' to 'collector server' - Changed instance variable names from (app *Application) to (col *Collector) * Rename more instances of Application to Collector - renamed files in service/application* to service/collector* - replaced occurrences of app to col * Renamed references of service.Application to collector (or collector server) * Added number of PR * Fixed merge conflicts * Renamed ColSettings to CollectorSettings * Fixed naming error * Moved change log entry unreleased section From v0.28.0-beta to unreleased (breaking change) * Removed misplaced newline Co-authored-by: Karen Xu <karenyrxu@gmail.com> Co-authored-by: Iris Song <chengcs@amazon.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
…#3414) Implements a simple store that will be used to record stale metrics; those that are NOT present in the current scrape, but were in the prior scrape. This logic will then be attached to our receiver logic to then complete the mechanism and then issue stale markers. Updates open-telemetry#3413 Updates open-telemetry#2961
Change obsreport helpers for scraper to use the same pattern as Processor/Exporter and modified existences in the code. **Link to tracking Issue:** [Issue open-telemetry#3313](open-telemetry#3313)
…comment (open-telemetry#3334) Update attributes in the `config.yaml` of attributes processor. So the regex value is consistent with the comment above it, as suggested in the issue. **Link to tracking Issue:** open-telemetry#2843
alolita
approved these changes
Jun 18, 2021
JamesJHPark
pushed a commit
that referenced
this pull request
Nov 3, 2021
Fixes #67 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
JamesJHPark
pushed a commit
that referenced
this pull request
Nov 3, 2021
* Initial commit * Add CODEOWNERS file (#2) * Add CODEOWNERS file * Update CODEOWNERS * Moved from github.com/observatorium/opentelemetry-collector-builder (#3) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * fixed panics (#6) Signed-off-by: Joe Elliott <number101010@gmail.com> * Replace master with main in CI and mergify files (#8) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Bump to OpenTelemetry Collector 0.20.0 (#10) Closes #9 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Explicitly enable Go modules in quickstart instructions (#13) * Update to collector v0.21.0 (#17) Fixes #16 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Update to collector v0.22.0 (#19) * Download go modules before building (#20) Fixes #14 * Add version command (#25) Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Pass errors from cobra Execute back to main for correct exit code (#28) * pass errors from cobra execute back to main * print the error * Update to collector v0.23.0 (#27) * Generate a warning if the builder and collector base version mismatch (#30) * Generate a warning if the builder and collector base version mismatch * Show current default version in the warning message * Update to OpenTelemetry Collector 0.24.0 * Don't use %w formatting with log.Fatal (#35) * Update to OpenTelemetry Collector 0.25.0 (#36) Signed-off-by: Serge Catudal <serge.catudal@gmail.com> * Update to 0.26.0 and update BuildInfo (#39) * Sync build and CI Go versions at latest 1.16 (#34) * Sync build and CI Go versions at latest 1.16 * Run go mod tidy * Set go binary to use in the compilation phase in tests Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Add option to generate go code only (no compile) (#40) * Issue#24 Add option to generate go code only (no compile) * Update cmd/root.go logging Suggested by @jpkkrohling Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> * remove verbose help .. created by corba * suggestion by jpkrohling to keep generateandcompile * lint error: remove unused var * reword cmd option and add back help message for default Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> * Don't reuse exec.Cmd (#42) * Update to OpenTelemetry Collector 0.27.0 (#43) * Add CI Badge (#47) * Update to Collector v0.28.0 (#49) * Update to Collector v0.28.0 Closes #48 Addresses the breaking API change in open-telemetry#3163, besides the usual version number changes. Signed-off-by: Fangyi Zhou <me@fangyi.io> * Use `go mod tidy` instead of `go mod download` It appears that this magically resolves the go.mod file issue. https://stackoverflow.com/questions/67203641/missing-go-sum-entry-for-module-providing-package-package-name Signed-off-by: Fangyi Zhou <me@fangyi.io> * Account for go mod download in go1.17 not updating go.sum (#50) * Update to collector v0.29.0 (#54) * Update replaces.builder.yaml * Update nocore.builder.yaml * Update config.go * Update README.md * Update main.go * Update to collector v0.30.0 (#57) * cmd: fix module flag default value to github.com/open-telemetry (#58) Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com> * Update to collector v0.31.0 (#60) * Update to v0.33.0 (#62) Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * Add excludes support to generated go.mod (#63) Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Small cleanup for the builder files (#64) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Support building with Go 1.17 (#66) * Support building with Go 1.17 Fixes #65 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Update workflows to use Go 1.17 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Add gosec exceptions for exec.Command Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Update to OpenTelemetry core 0.34.0 (#68) Fixes #67 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Upgrade to OpenTelemetry Collector 0.35.0 (#70) Signed-off-by: Fangyi Zhou <me@fangyi.io> * Upgrade to OpenTelemetry Collector 0.36.0 (#76) * Generate custom service code for Windows (#75) * update main to include windows service code * use main version from tag 0.35.0 * update main function * align with upstream v0.36.0 tag * dummy change to trigger build * Revert "dummy change to trigger build" This reverts commit 629d499461da2d2c240bf1e495b5fe0558e3547f. * Remove Core from Module type (#77) Fixes #15 Signed-off-by: yugo-horie <u5.horie@gmail.com> * release 0.37.0 (#78) * release 0.37.0 * update use of NewCommand * Move builder to subdirectory Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Bogdan Drutu <lazy@splunk.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Joe Elliott <joe.elliott@grafana.com> Co-authored-by: Eric Yang <jiwen624@gmail.com> Co-authored-by: Brian Gibbins <eroteme@supernought.co.uk> Co-authored-by: Ashmita <ashmita.bohara152@gmail.com> Co-authored-by: Fangyi Zhou <me@fangyi.io> Co-authored-by: Shaun Creary <65406540+crearys@users.noreply.github.com> Co-authored-by: Patryk Małek <69143962+pmalek-sumo@users.noreply.github.com> Co-authored-by: Serge Catudal <serge.catudal@gmail.com> Co-authored-by: Aaron Stone <aaron@serendipity.cx> Co-authored-by: Patryk Małek <pmalek@sumologic.com> Co-authored-by: Aaron Stone <aaron.stone@udacity.com> Co-authored-by: Kelvin Lo <kello@live.ca> Co-authored-by: Himanshu <addyjeridiq@gmail.com> Co-authored-by: Y.Horie <u5.horie@gmail.com> Co-authored-by: Koichi Shiraishi <zchee.io@gmail.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Cal Loomis <68860480+loomis-relativity@users.noreply.github.com> Co-authored-by: alrex <aboten@lightstep.com>
vasireddy99
pushed a commit
that referenced
this pull request
May 2, 2023
* Instrument proctelemetry.ProcessMetrics (#67) * Instrument proctelemetry.ProcessMetrics * add chloggen * fix lint and remove unneeded context * catch potential case where some metricValues are 0 * address review feedback * rebase and remove unneeded registry * only run assertMetrics for OC * address review comments * rebase and update featuregate function in use * rebase and update to use new otel metrics api * fix lint err * address feedback * newline * use multierr for errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds a Github Actions workflow which checks for API compatibility of the incoming PR. This workflow utilizes Makefile targets that use the apidiff tool to compare public API snapshots. Overall, this workflow generates snapshots of the incoming PR and compares to snapshots of HEAD, logs the compatible and incompatible changes, then fails if there are any incompatible changes. This workflow will run on every PR to main and check if there are any breaking changes.
Link to tracking Issue: Addresses issue # 3220.
Testing: A snapshot was created from the v0.23.x release and compared against the current HEAD:
Click to expand!
Documentation: There is usage output for the internal script.