Disallow renaming metrics using the prometheus receiver #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
disallow_target_name
branch
3 times, most recently
from
4c903c1
to
4641b6e
Compare
carlosalberto
approved these changes
Jun 11, 2021
rakyll
approved these changes
Jun 11, 2021
dashpole
force-pushed
the
disallow_target_name
branch
from
4641b6e
to
419627c
Compare
alolita
approved these changes
Jun 15, 2021
alolita
added
area:prometheus
area:receiver
ready-to-merge
bogdandrutu
approved these changes
Jun 15, 2021
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Don't allow changing the metric name using prometheus metric_relabel_configs. This doesn't currently work (https://github.com/open-telemetry/opentelemetry-collector/issues/2297), and can't easily be made to work (prometheus/prometheus#8893). Until we can make it work correctly, we should fail loudly.
Link to tracking Issue:
Issue: https://github.com/open-telemetry/opentelemetry-collector/issues/2297
Testing:
Unit tests added