Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix loss parse in val_step #906

Merged
merged 3 commits into from
Sep 26, 2021
Merged

[Fix] Fix loss parse in val_step #906

merged 3 commits into from
Sep 26, 2021

Conversation

acdart
Copy link
Contributor

@acdart acdart commented Sep 25, 2021

Motivation

Add loss parse in val_step, so that logger can get loss value of validation dataset

Modification

add loss parse and format output dict in val_step function

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2021

CLA assistant check
All committers have signed the CLA.

@Junjun2016
Copy link
Collaborator

Hi @acdart
Thanks for your contribution.
It would be better to add some unittests if your time is available.

@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #906 (bd2aebb) into master (186a1fc) will increase coverage by 0.23%.
The diff coverage is 100.00%.

❗ Current head bd2aebb differs from pull request most recent head d496e1d. Consider uploading reports for the commit d496e1d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
+ Coverage   89.09%   89.33%   +0.23%     
==========================================
  Files         112      112              
  Lines        6081     6083       +2     
  Branches      977      977              
==========================================
+ Hits         5418     5434      +16     
+ Misses        468      452      -16     
- Partials      195      197       +2     
Flag Coverage Δ
unittests 89.33% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/segmentors/base.py 58.65% <100.00%> (+14.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 186a1fc...d496e1d. Read the comment docs.

Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Junjun2016 Junjun2016 requested a review from xvjiarui September 25, 2021 06:55
@xvjiarui xvjiarui merged commit 29c82ea into open-mmlab:master Sep 26, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* [Fix] Fix loss parse in val_step

* Add val_step unittest

* Add train_step unittest
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* ONNX supervised inpainting

* sync with the torch pipeline

* fix concat

* update ref values

* back to 8 steps

* type fix

* make fix-copies
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
* paf detector

* add paf detector & head & loss

* rename to PartAffinityField

* rebase master

* add paper ref

* fix tab indent

* update show

* update heads

* update heads

* update paf head

* update docstring

* integrate get_multi_stage_outputs function for ae and paf

* delete PAFParser

* refactor ae

* rm project2image in aggregate_scale

* update head/init

* update paf post-processing

* fix docstring

* fix docstring

* fix config

* add res50 config

* add res50 config

* fix bugs in paf generator

* update paf flip

* update paf group

* update deconvhead

* paf + head

* fix config

* update post-processing

* fix bugs in flip paf

* update unittest

* add 'align_corners' in cfg

* update refine

* handle empty list

* fix order

* update pose filter

* add openpose network

* add openpose_v1 and openpose_v2 model

* fix openpose v1

* rename stem to features for pre-trained vgg model loading

* add openpose v1 v2 configs

* add with_bg

* allow different num_blocks and block_channels for different stages

* remove redundant settings

* update lightweight openpose

* add lightopenpose config

* update pretrained

* update config

* add neck & modify skeleton

* rename addneck cfg

* BottomUpGenerateHeatmapTarget pipeline with add_neck

* BottomUpGenerateHeatmapTarget pipeline with add_neck

* update addneck cfg

* copy to keep self.coco unchanged

* update pipeline with addneck

* train paf wholebody

* add bn

* add bn

* get add_neck on dataset

* fix unittest

* fix test with addneck

* fix with bg

* fix lightweight openpose with_bg=False

* fix config

* fix conv bias

* fix with_bg config

* fix paf

* update config

* gamma 0.333

* sgd config

* fix MaskedMSELoss & add supervise_empty

* fix add_neck

* cfg of paf wholebody withbg + pretrain + supervise_empty

* update lr

* fix cfg

* fix cfg

* update configs

* update configs

* add configs

* update configs

* update configs

* fix unittest

* paf wholebody with hrnet/openposev2 backone

* update cfg

* add hourglass_ae model

* add hourglass_ae model

* add hourglass_ae model

* update unittest

* update hourglass

* add select_output_index

* supervise_empty=False

* update batch size

* resume from 50 epoch

* hourglass wholebody coco pretrain

* release resource limit

* resume from 100ep

* reduce workers_per_gpu

* test multi-scale coco

* delete paf

* fix forward test

* fix pytest

* update batch size

* update cfg

Co-authored-by: jinsheng <jinsheng@sensetime.com>
Co-authored-by: jin-s13 <jinsheng13@foxmail.com>
Co-authored-by: 金晟 <SENSETIME\jinsheng@stit10.domain.sensetime.com>
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
* add json output for video demo

* add json output for long_video_demo

* add json output video demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants