Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The val function code in the workflow process does not work properly, and the code parameters do not match #905

Conversation

liujianghao
Copy link

@liujianghao liujianghao commented Sep 24, 2021

Def val_step(self, data_batch, **kwargs) in base.py has no optimizer,
However,the outputs = self.model. val_step(data_batch, self. optimizer, **kwargs) in epoch_based_runner.py contains the parameter "optimizer".

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #905 (e30d72e) into master (186a1fc) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e30d72e differs from pull request most recent head 15071c0. Consider uploading reports for the commit 15071c0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #905   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files         112      112           
  Lines        6081     6081           
  Branches      977      977           
=======================================
  Hits         5418     5418           
  Misses        468      468           
  Partials      195      195           
Flag Coverage Δ
unittests 89.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/segmentors/base.py 44.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 186a1fc...15071c0. Read the comment docs.

@Junjun2016
Copy link
Collaborator

Junjun2016 commented Sep 24, 2021

Hi @liujianghao
Thanks for your contribution!
Please fix the lint error and use English.

@liujianghao liujianghao changed the title workflow 流程里的val 功能代码不能正常运行,代码传参不匹配,有bug #904 kwargs) in base.py has no optimizer, However,the outputs = self.model. val_step(data_batch, self. optimizer, **kwargs) in epoch_based_runner.py contains the parameter "optimizer". Sep 26, 2021
@liujianghao liujianghao changed the title kwargs) in base.py has no optimizer, However,the outputs = self.model. val_step(data_batch, self. optimizer, **kwargs) in epoch_based_runner.py contains the parameter "optimizer". The val function code in the workflow process does not work properly, and the code parameters do not match Sep 26, 2021
@Junjun2016 Junjun2016 closed this Sep 26, 2021
@Junjun2016
Copy link
Collaborator

Hi @liujianghao
Thanks for your contribution.
The bug has been fixed in #906.

@OpenMMLab-Assistant005
Copy link

Hi @liujianghao !We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants