Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update TimeSformer models' README & metafile #2124

Merged
merged 6 commits into from
Dec 26, 2022
Merged

[Doc] Update TimeSformer models' README & metafile #2124

merged 6 commits into from
Dec 26, 2022

Conversation

hukkai
Copy link
Collaborator

@hukkai hukkai commented Dec 8, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily got feedback.
If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduces changes that break the back-compatibility of this repo?
If so, please describe how it breaks the compatibility and how users should modify their codes to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools should be used to fix the potential lint issues.
  2. The modification should be covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation should be modified accordingly, like docstring or example tutorials.

@hukkai hukkai changed the title [Doc] Update TimeSformer models' accuracy [Doc] Update TimeSformer models' README & metafile Dec 8, 2022
@codecov
Copy link

codecov bot commented Dec 9, 2022 •
edited
Loading

Codecov Report

Base: 75.35% // Head: 75.35% // No change to project coverage 👍

Coverage data is based on head (3981594) compared to base (37ce660).
Patch has no changes to coverable lines.

❗ Current head 3981594 differs from pull request most recent head c7fcf5a. Consider uploading reports for the commit c7fcf5a to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           dev-1.x    #2124   +/-   ##
========================================
  Coverage    75.35%   75.35%           
========================================
  Files          143      143           
  Lines        10856    10856           
  Branches      1780     1780           
========================================
  Hits          8180     8180           
  Misses        2269     2269           
  Partials       407      407
Flag Coverage Δ
unittests 75.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hukkai hukkai assigned ly015 and unassigned Dai-Wenxun Dec 9, 2022
ly015
ly015 reviewed Dec 12, 2022
View reviewed changes
configs/recognition/timesformer/timesformer_spaceOnly_8xb8-8x32x1-15e_kinetics400-rgb.py Outdated
Comment on lines 38 to 41
# file_client_args = dict(
# io_backend='petrel',
# path_mapping=dict(
# {'data/kinetics400': 's3://openmmlab/datasets/action/Kinetics400'}))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part should be removed.

ly015
ly015 reviewed Dec 12, 2022
View reviewed changes
configs/recognition/timesformer/README.md
e.g., lr=0.005 for 8 GPUs x 8 videos/gpu and lr=0.00375 for 8 GPUs x 6 videos/gpu.
| frame sampling strategy | resolution | gpus | backbone | pretrain | top1 acc | top5 acc | testing protocol | FLOPs | params | config | ckpt | log |
| :---------------------: | :--------: | :--: | :---------------------: | :----------: | :------: | :------: | :--------------: | :---: | :----: | :----------------------------: | :--------------------------: | :-------------------------: |
| 8x32x1 | 224x224 | 8 | TimeSformer (divST) | ImageNet-21K | 77.69 | 93.45 | 1 clip x 3 crop | 196G | 122M | [config](/configs/recognition/timesformer/timesformer_divST_8xb8-8x32x1-15e_kinetics400-rgb.py) | [ckpt](https://download.openmmlab.com/mmaction/v1.0/recognition/timesformer/timesformer_divST_8xb8-8x32x1-15e_kinetics400-rgb/timesformer_divST_8xb8-8x32x1-15e_kinetics400-rgb_20220815-a4d0d01f.pth) | [log](https://download.openmmlab.com/mmaction/v1.0/recognition/timesformer/timesformer_divST_8xb8-8x32x1-15e_kinetics400-rgb/timesformer_divST_8xb8-8x32x1-15e_kinetics400-rgb.log) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the resolution setting changed?

@ly015 ly015 merged commit c62f9c2 into open-mmlab:dev-1.x Dec 26, 2022
hukkai added a commit to hukkai/mmaction2 that referenced this pull request Jan 6, 2023
@hukkai
[Doc] Update TimeSformer models' README & metafile (open-mmlab#2124)
d6f6a86
ly015 pushed a commit that referenced this pull request Jan 10, 2023
@hukkai @ly015
[Doc] Update TimeSformer models' README & metafile (#2124)
91f8cdc
cir7 pushed a commit to Andy1621/mmaction2 that referenced this pull request Jan 16, 2023
@Andy1621 @cir7
add uniformerv1&v2
771dfa6 
debug doc of uniformerv1&v2

debug pre-commit of uniformerv1&v2

debug doc

[Refactor] Refactor and Enhance 2s-AGCN (open-mmlab#2130)

[Doc] Update TSN models' README & metafile  (open-mmlab#2122)

[Doc] Update TimeSformer models' README & metafile  (open-mmlab#2124)

fix mvit readme (open-mmlab#2125)

[Doc] Update SlowOnly models' README & metafile  (open-mmlab#2126)

Co-authored-by: wxDai <wxDai2001@gmail.com>

[Doc] Update TRN models' README & metafile  (open-mmlab#2129)

debug merge

debug doc and test

debug doc

fix init_weight

update readme

update readme

fix the readme
cir7 pushed a commit to Andy1621/mmaction2 that referenced this pull request Jan 16, 2023
@Andy1621 @cir7
add uniformerv1&v2
fad066c 
debug doc of uniformerv1&v2

debug pre-commit of uniformerv1&v2

debug doc

[Refactor] Refactor and Enhance 2s-AGCN (open-mmlab#2130)

[Doc] Update TSN models' README & metafile  (open-mmlab#2122)

[Doc] Update TimeSformer models' README & metafile  (open-mmlab#2124)

fix mvit readme (open-mmlab#2125)

[Doc] Update SlowOnly models' README & metafile  (open-mmlab#2126)

Co-authored-by: wxDai <wxDai2001@gmail.com>

[Doc] Update TRN models' README & metafile  (open-mmlab#2129)

debug merge

debug doc and test

debug doc

fix init_weight

update readme

update readme

fix the readme
cir7 pushed a commit to Andy1621/mmaction2 that referenced this pull request Feb 1, 2023
@Andy1621 @cir7
add uniformerv1&v2
ca22e94 
debug doc of uniformerv1&v2

debug pre-commit of uniformerv1&v2

debug doc

[Refactor] Refactor and Enhance 2s-AGCN (open-mmlab#2130)

[Doc] Update TSN models' README & metafile  (open-mmlab#2122)

[Doc] Update TimeSformer models' README & metafile  (open-mmlab#2124)

fix mvit readme (open-mmlab#2125)

[Doc] Update SlowOnly models' README & metafile  (open-mmlab#2126)

Co-authored-by: wxDai <wxDai2001@gmail.com>

[Doc] Update TRN models' README & metafile  (open-mmlab#2129)

debug merge

debug doc and test

debug doc

fix init_weight

update readme

update readme

fix the readme
cir7 pushed a commit to Andy1621/mmaction2 that referenced this pull request Feb 8, 2023
@Andy1621 @cir7
add uniformerv1&v2
6dc1220 
debug doc of uniformerv1&v2

debug pre-commit of uniformerv1&v2

debug doc

[Refactor] Refactor and Enhance 2s-AGCN (open-mmlab#2130)

[Doc] Update TSN models' README & metafile  (open-mmlab#2122)

[Doc] Update TimeSformer models' README & metafile  (open-mmlab#2124)

fix mvit readme (open-mmlab#2125)

[Doc] Update SlowOnly models' README & metafile  (open-mmlab#2126)

Co-authored-by: wxDai <wxDai2001@gmail.com>

[Doc] Update TRN models' README & metafile  (open-mmlab#2129)

debug merge

debug doc and test

debug doc

fix init_weight

update readme

update readme

fix the readme
@hukkai hukkai deleted the timesformer branch June 15, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ly015 ly015 ly015 approved these changes

Assignees

@ly015 ly015

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hukkai @ly015 @Dai-Wenxun