Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility improvements - Visibility and navigation #4720

Closed
6 tasks done
Tracked by #4622
robinmolen opened this issue Oct 1, 2024 · 4 comments · Fixed by #4776, open-formulieren/open-forms-sdk#721 or open-formulieren/open-forms-sdk#725
Closed
6 tasks done
Tracked by #4622

Accessibility improvements - Visibility and navigation #4720

robinmolen opened this issue Oct 1, 2024 · 4 comments · Fixed by #4776, open-formulieren/open-forms-sdk#721 or open-formulieren/open-forms-sdk#725
Assignees
@robinmolen
Labels
enhancement topic: a11y Accessibility issues
Milestone
Release 3.0

Comments

@robinmolen
Copy link
Contributor

robinmolen commented Oct 1, 2024 •
edited
Loading

Thema / Theme

Frontend

Omschrijving / Description

This issue is related to #4622

This issue targets the visibility and navigation improvements of the accessibility rapport:

  • 2.1.1
  • 2.4.1
  • 2.4.2
  • 2.4.4
  • 2.4.6
  • 2.4.7

Added value / Toegevoegde waarde

No response

Aanvullende opmerkingen / Additional context

No response
@robinmolen robinmolen added enhancement topic: a11y Accessibility issues labels Oct 1, 2024
@robinmolen robinmolen added this to the Release 3.0 milestone Oct 1, 2024
@robinmolen robinmolen self-assigned this Oct 1, 2024
@robinmolen robinmolen mentioned this issue Oct 1, 2024
Open
22 tasks
@robinmolen
Copy link
Contributor Author

2.1.1 is fixed/solved by the changes of #4717. The close button is now an actual button element

robinmolen added a commit to open-formulieren/design-tokens that referenced this issue Oct 21, 2024
@robinmolen
♿ [open-formulieren/open-forms#4720] Added design tokens for skiplink
65a2ddc
robinmolen added a commit that referenced this issue Oct 21, 2024
@robinmolen
♿ [#4720] Skiplink as first focusable element and visible on focus
0b3d231
@robinmolen
Copy link
Contributor Author

For WCAG 2.4.3 Focus Order we might have some issues. Various elements change in order when resizing the view (or when you increase the zoom on the browser). These order changes are only visual, meaning that the tab-order follows the order of the DOM. This results into an unexpected tab-order.

Elements that are involved:

  • the buttons below the forms
  • the progress menu

The easiest solution would be to prevent/remove the order changes, but this will have an impact on the UI

robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Oct 21, 2024
@robinmolen
♿ [open-formulieren/open-forms#4720] Focusable elements
702a582
robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Oct 21, 2024
@robinmolen
♿ [open-formulieren/open-forms#4720] Self explaining links
3670d6d
@robinmolen
Copy link
Contributor Author

2.4.7 the skiplink is now the first focusable element in the dom tree. When this element receives focus, it will be shown

robinmolen added a commit that referenced this issue Oct 21, 2024
@robinmolen
🌐 [#4720] Added translations
91cb15d
robinmolen added a commit that referenced this issue Oct 21, 2024
@robinmolen
♿ [#4720] More descriptive submission report pdf title
3ffcb98
robinmolen added a commit that referenced this issue Oct 21, 2024
@robinmolen
🌐 [#4720] Updated translations
aa824c3
@robinmolen
Copy link
Contributor Author

2.4.2 The form name is now part of the submission report PDF filename. Changes for the page titles still needs to happen

This was referenced Oct 21, 2024
Merged
Merged
Closed
robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Oct 22, 2024
@robinmolen
♿ [open-formulieren/open-forms#4720] Self explaining links
88847e8
@robinmolen robinmolen moved this from Todo to In Progress in Development Oct 22, 2024
robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Oct 22, 2024
@robinmolen
✨ [open-formulieren/open-forms#4720] Added form name to the title of …
92f793b 
…the form step pages
sergei-maertens pushed a commit to open-formulieren/open-forms-sdk that referenced this issue Oct 24, 2024
@robinmolen @sergei-maertens
♿ [open-formulieren/open-forms#4720] Focusable elements
b2f58fb
sergei-maertens pushed a commit to open-formulieren/open-forms-sdk that referenced this issue Oct 24, 2024
@robinmolen @sergei-maertens
♿ [open-formulieren/open-forms#4720] Self explaining links
eb0e1ac
sergei-maertens pushed a commit to open-formulieren/open-forms-sdk that referenced this issue Oct 24, 2024
@robinmolen @sergei-maertens
✨ [open-formulieren/open-forms#4720] Added form name to the title of …
88dc2df 
…the form step pages
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Oct 24, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Development Oct 24, 2024
sergei-maertens pushed a commit that referenced this issue Oct 28, 2024
@robinmolen @sergei-maertens
♿ [#4720] Skiplink as first focusable element and visible on focus
28978f4
sergei-maertens pushed a commit that referenced this issue Oct 28, 2024
@robinmolen @sergei-maertens
🌐 [#4720] Added translations
3d4e3bb
sergei-maertens pushed a commit that referenced this issue Oct 28, 2024
@robinmolen @sergei-maertens
♿ [#4720] More descriptive submission report pdf title
ae57a04
robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Oct 28, 2024
@robinmolen
♿ [open-formulieren/open-forms#4720] Moved accessible link text to ar…
5bfb73b 
…ia-label

The added context doesn't add anything for users that don't use screenreaders. So the additional context should only be used when it is needed
robinmolen added a commit that referenced this issue Oct 28, 2024
@robinmolen
♿ [#4720] Skiplink as first focusable element and visible on focus
8c6133e
robinmolen added a commit that referenced this issue Oct 28, 2024
@robinmolen
🌐 [#4720] Added translations
6ad4349
robinmolen added a commit that referenced this issue Oct 28, 2024
@robinmolen
♿ [#4720] More descriptive submission report pdf title
95ce084
@robinmolen robinmolen linked a pull request Oct 28, 2024 that will close this issue
Accessible file upload link open-formulieren/open-forms-sdk#725
Merged
robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Oct 28, 2024
@robinmolen
♿ [open-formulieren/open-forms#4720] Moved accessible link text to ar…
7da8a0c 
…ia-label

The added context doesn't add anything for users that don't use screenreaders. So the additional context should only be used when it is needed
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Oct 28, 2024
robinmolen added a commit that referenced this issue Oct 28, 2024
@robinmolen
✅ [#4720] Fixed e2e test
9d3b9ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinmolen robinmolen

Labels
enhancement topic: a11y Accessibility issues
Projects
Development
Archived in project
Milestone
Release 3.0
2 participants
@sergei-maertens @robinmolen