Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toegankelijkheidsverbeteringen Q1-2025 #4622

Open
22 tasks done
joeribekker opened this issue Aug 27, 2024 · 5 comments
Open
22 tasks done

Toegankelijkheidsverbeteringen Q1-2025 #4622

joeribekker opened this issue Aug 27, 2024 · 5 comments
Assignees
Labels
owner: dimpact topic: a11y Accessibility issues
Milestone

Comments

@joeribekker
Copy link
Contributor

joeribekker commented Aug 27, 2024

Versie: 2.6.13

Ruwe eerste inschattingen op basis van rapport (op te vragen bij Joeri).

  • 1.3.1 Info en relaties (3 dagen)
  • 1.3.5 Identificeer het doel van de input (config?)
  • 1.4.11 Contrast van niet-tekstuele content (config? maar wellicht betere default)
    2.5.3 Label in naam (zelfde als 1.3.1?)
  • Accessibility improvements - Form fields #4716

Totaal: 13 dagen werk

@joeribekker joeribekker added triage Issue needs to be validated. Remove this label if the issue considered valid. topic: a11y Accessibility issues enhancement labels Aug 27, 2024
@joeribekker joeribekker added this to the Release 3.0 milestone Sep 26, 2024
robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 26, 2024
robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 26, 2024
…nsible input

Using aria-describedby to explain which input is responsible for the error
robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 26, 2024
robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 26, 2024
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Sep 30, 2024
@joeribekker joeribekker changed the title [CONCEPT] Accessibility improvements Accessibility improvements Sep 30, 2024
robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 30, 2024
@joeribekker
Copy link
Contributor Author

@robinmolen can you edit the original ticket and hang them below the relevant bullet?

@vaszig vaszig added the meta label Oct 2, 2024
robinmolen added a commit to open-formulieren/design-tokens that referenced this issue Oct 2, 2024
@robinmolen
Copy link
Contributor

Issue 2.5.3 is about the datepicker inputs that currently aren't connected to their labels. I've discussed this issue with Sergei, and we came to the conclusion that this issues cannot be resolved at this time.

The current datepicker (flatpickr) has some accessibility issues that we cannot solve. In the future, if/when we can use the pure React datepicker, this issue will be solved. Unfortunately we can't do anything at this time

@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Nov 12, 2024
@joeribekker joeribekker modified the milestones: Release 3.0, Release 3.1.0 Dec 2, 2024
@joeribekker joeribekker reopened this Dec 4, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Development Dec 4, 2024
@joeribekker joeribekker moved this from In Progress to Done in Development Dec 4, 2024
@joeribekker joeribekker closed this as completed by moving to Done in Development Dec 4, 2024
@joeribekker joeribekker reopened this Dec 4, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Development Dec 4, 2024
@joeribekker joeribekker changed the title Accessibility improvements Toegankelijkheidsverbeteringen Q1-2025 Dec 4, 2024
@sergei-maertens sergei-maertens moved this from In Progress to Todo in Development Jan 6, 2025
@sergei-maertens
Copy link
Member

Can't estimate without having seen the accessiblity report(s)

robinmolen added a commit that referenced this issue Jan 28, 2025
The previous textual alternative, using `aria-label`, wasn't targetable by screen readers (tested using the macOS VoiceOver screen reader).
By providing the textual alternative as real content the screen reader can find and read the content.
@robinmolen
Copy link
Contributor

robinmolen commented Jan 28, 2025

November 26th a new Accessibility test was performed which resulted into a new rapport. Most items in this rapport are 'small' improvements (color contrasts, changing html elements), but there are also a couple 'larger' issues. The list below contains the rapported accessibilty items, which I've tests with the macOS VoiceOver screenreader:

Improvements that should be relatively simple:

  • 1.1.1 (non-textual content) The logo in the pdf contains a textual alternative, but cannot be accessed.
  • 1.3.1 (information and relations) Missing relations between (submission rapport) PDF field labels and values.
  • 1.3.1 (information and relations) When a (submission rapport) PDF field doesn't have a values, we should provide a "No information provided" alternative. (This is to ensure that users understand that a field was left empty)
  • 1.4.3 (color contrast) Error messages have a contrast of 3,7:1. This should be 4,5:1
  • 1.4.11 (non-textual color contrast) Checkbox and radio button borders have a contrast of 2,9:1. This should be 3,0:1
  • 2.1.1 (navigation - keyboard) Tooltip cannot be accessed by screen readers
  • 2.4.2 (navigation - page title) The title in the PDF meta description contains leading and trailing whitespace
  • 3.1.2 (language) Some texts are non translatable. The rapport mentions the title of the select component delete button.
  • 4.1.2 (name, role, value) The dropdown variant of the progress menu doesn't contain aria-expanded information

All these smaller improvements should be completable in around 3 days

Improvements that are a bit more complicated:

  • 2.4.7 (navigation - focus visibility) When the form is displayed on a small screen, or greatly zoomed-in, the progress menu will be shown as a dropdown menu. When you focus any menu items in the dropdown, and repeatable press the tab key, you can place the focus outside the menu. The menu stays expended, resulting in the focused element not being visible.
    This might required some major re-writing.
    Could take a couple of days
  • 3.3.3 (error suggestion) When a specific input pattern is expected, the error message should provide the expected format or an example.
    With examples in the error messages this could be resolved in 1 day.
  • 4.1.2 (name, role, value) The select component contains problems with name and role on the select element, aria-selected="true" on the parent div, missing aria tags
    This could be resolved in 2 days (It could be that we cannot fix the issues for this component. Lets start with a time-box of 1/2 day, and assess from there)
  • 4.1.3 (status messages) The loading spinners have issues with aria-live which results into status updates not being announced
    This could be resolved in about 1 week

Estimate (including previously done work): 6 weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
owner: dimpact topic: a11y Accessibility issues
Projects
Status: Todo
Development

No branches or pull requests

4 participants