-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix colors option when using wildcard commands #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for taking this on!
concurrently -k -c cyan,yellow,green "npm:start-*" "bash foo.sh"
Will produce bash foo.sh to print as cyan or green,
Did you mean yellow or green? Or am I missing something in your fix..?
@gustavohenke when using this command Suppose you have only one script that matches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daniloraisi I've pushed a couple of changes to your branch to make prefixes specified per command be preferred over those specified in the prefixColors
option, plus added some docs and test.
We should be good to ship this now 🙌
Fix out in v6.3.0. |
This PR fix Issues #186, #210, and #234
Now when executing the command
will produce the same result as
When mixing commands like
Will producebash foo.sh
to print as cyan or yellow respectively since the prefixColor attribution for plain commands use original index args passed toconcurrently
script.Will produce
bash foo.sh
to print as cyan or green, since the attribution of prefixColor will happen after all commands are analyzed and prepared.