-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color changes for wild cards #186
Comments
I was analyzing the code, and it seems that the problem is the way concurrently prefix colors. As of this line: concurrently/bin/concurrently.js Line 153 in 0bc490f
It is considering only the first command to apply the color instead of applying each one when using a wildcard. The command parser needs a way to apply prefix color when splitting npm wildcards. @milahu, I can work on a PR to fix this. |
Fix out in v6.3.0. |
Love this tool. When I tried the following (
package.json
has twostart-
scripts):the output of both subtasks were displayed with cyan rather than the first being colored cyan and the second being colored yellow. Instructions indicate that when color count is less than command count, the last color listed is used. I suspect whatever does the color logging sees only the command line argument count (a single command) and doesn't realize its a wildcard command so doesn't look for the actual number of commands running. Or, the wildcard processing code doesn't update some command count global. Or, the wildcard processing code is somehow treated as only one process.
In any event, it'd be nice to have wildcard initiated commands individually colored.
My work around is to just explicitly start the commands by name and I still get the coloring. This works:
In addition, to explore some edge cases, I wrote a simple shell script that prints to the terminal and sleeps (see below). When I run it in with the wildcard, the wildcard logging is treated as a single process. Examples:
The first line outputs the shell logging in cyan and the two wildcards in yellow.
The second line outputs the two wildcards in cyan and the shell logging in yellow.
foo.sh
The text was updated successfully, but these errors were encountered: