Accept read_write_scope from opts when calling cast functions directly #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertored
changed the title
albertored
force-pushed
the
read-write-scope-reference
branch
from
ec00ec1 to
881c01c
Compare
This was referenced May 24, 2024
nathanalderson
pushed a commit
to Tango-Tango/open_api_spex
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_write_scopeis needed fort correctly handlingreadOnlyandwriteOnlyrequired properties but it is non populated when calling directly cast functions. This adds that option.There was also a problem when the property marked as
readOnlyorwriteOnlyis inside a reference. Before this change thecheck_required_fieldsfunction took as input the originalctxwith properties not yet resolved. Now thectxis updated with resolved properties and the required check works as expected. In doing so I also changed a little bit theObjectmodule to make all functions modify and accept the samectxmaking the code much more readable.Fixes #499 and supersedes #513