Fix cast_and_validate/5 to properly handle required readOnly fields
#513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbuhot
reviewed
Nov 22, 2022
mbuhot
reviewed
Nov 22, 2022
mbuhot
reviewed
Nov 24, 2022
| defp get_property_schema(ctx, property_name) do | ||
| case ctx.schema.properties[property_name] do | ||
| schema = %_{} -> OpenApiSpex.resolve_schema(schema, ctx.schemas) | ||
| _ -> nil |
There was a problem hiding this comment.
When does execution reach this line? When there's a value in the required list that doesn't correspond to a key in the properties map?
|
Anything needed to move this on? |
|
Resolved by #572 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix a bug described in #499. The bug leads to
OpenApiSpex.cast_and_validate/5consideringreadOnlyfields to be required in the request body. A fix is achieved by adding an ability to passread_write_scopefromOperation2/CastParametersto object casting code.