Avoids overwriting Plug.Conn body_params and params with the cast outcome #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbuhot did you have the chance to review this? Is there something missing to have it merged? (sorry for bothering you) |
|
Thanks for the ping @albertored. This PR is very close.
|
albertored
force-pushed
the
cast-to-private
branch
from
a05585e to
9958c2e
Compare
|
@mbuhot all your suggestions are now implemented |
mbuhot
reviewed
Mar 23, 2022
There was a problem hiding this comment.
@albertored just one final suggestion to keep the values under conn.private.open_api_spex (like we do for PutApiSpec) to prevent potential clashes with other plugs that OpenApiSpex users have in their apps.
albertored
commented
Mar 23, 2022
albertored
commented
Mar 23, 2022
albertored
commented
Mar 23, 2022
albertored
commented
Mar 23, 2022
albertored
force-pushed
the
cast-to-private
branch
from
f4aab1d to
1bc81db
Compare
|
@mbuhot it should be ready now, thank you |
mbuhot
approved these changes
May 15, 2022
This was referenced May 15, 2022
aerosol
added a commit
to plausible/analytics
that referenced
this pull request
Sep 28, 2023
aerosol
added a commit
to plausible/analytics
that referenced
this pull request
Sep 28, 2023
aerosol
added a commit
to plausible/analytics
that referenced
this pull request
Oct 2, 2023
aerosol
added a commit
to plausible/analytics
that referenced
this pull request
Oct 2, 2023
* Update depenedencies: OpenAPISpex + cursor based pagination * Update formatter config * Add internal server error implementation * Test errors * Implement pagination interface * Implement Plugins API module macros * Implement Public API base URI (to be used with path helpers once called from within forwarded router's scope) * Implement OpenAPI specs + schemas * Implement Shared Links context module * Add pagination and error views * Add Shared Link view * Implement Shared Link controller * Expose SharedLink.t() spec * Implement separate router for the Plugins API * Update moduledocs * Always wrap resource objects with `data` * Update moduledoc * Use open-api-spex/open_api_spex#425 due to open-api-spex/open_api_spex#92 * Rely on BASE_URL for swagger-ui server definition * Fixup goals migration * Migrate broken goals before deleting dupes * Remove bypassing test rate limiting for which there's none anyway * Move the context module under `Plausible.` namespace * Bring back conn assignment to PluginsAPICase template * Update test/plausible_web/plugins/api/controllers/shared_links_test.exs Co-authored-by: Uku Taht <Uku.taht@gmail.com> * Update renamed aliases * Seed static token for development purposes * Delegate Plugins API 500s to a familiar shape * Simplify with statement --------- Co-authored-by: Uku Taht <Uku.taht@gmail.com>
github-actions bot
pushed a commit
to kphrx/pleroma
that referenced
this pull request
Jan 30, 2024
…ided by the :replace_params config option This allows us to configure Open API Spex to not overwrite the params with the casted versions which violates the Plug.Conn.t() contract open-api-spex/open_api_spex#92 open-api-spex/open_api_spex#425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #398 and #376
As aked in this comment the flag for moving cast result to
conn.privateis now an option toCastAndValidateplug.Credits to @riccardomanfrin and @lucacorti