-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop replacing Plug Conn params and body_params #376
Closed
lucacorti
wants to merge
9
commits into
open-api-spex:master
from
lucacorti:feature/move-params-to-conn-assigns
Closed
Stop replacing Plug Conn params and body_params #376
lucacorti
wants to merge
9
commits into
open-api-spex:master
from
lucacorti:feature/move-params-to-conn-assigns
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacorti
force-pushed
the
feature/move-params-to-conn-assigns
branch
from
July 24, 2021 18:52
70f0450
to
cb1b058
Compare
Not sure what is happening on 1.9. |
Elixir 1.9 is not compatible with OTP 23, so I excluded it from the current test matrix. https://hexdocs.pm/elixir/1.12/compatibility-and-deprecations.html |
Hi everyone! Any chance for this or 398 to enter the main tree? |
Closing in favour of #425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently
Plug.Conn
params
andbody_params
are replaced when casting viaOpenApiSpex.Plug.CastAndValidate
.This creates issues with dialyzer (#92) and apparently breaks
Plug.Upload
(#370) too.Unfortunately this can't be addressed in a backwards compatible way, so what I'm proposing in this PR is:
casted_body_params
andcasted_params
to conn assigns with the casted versionPlug.Conn
params
andbody_params
.This way this change could be immediately merged, and people can start migrating today if they need to.