Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webconnectivitylte: address remaining TODOs in the codebase #2669

Closed
bassosimone opened this issue Feb 7, 2024 · 0 comments · Fixed by ooni/probe-cli#1500
Closed

webconnectivitylte: address remaining TODOs in the codebase #2669

bassosimone opened this issue Feb 7, 2024 · 0 comments · Fixed by ooni/probe-cli#1500
Assignees
@bassosimone
Labels
funder/otffoss2023-2024

Comments

@bassosimone
Copy link
Contributor

No description provided.

@bassosimone bassosimone self-assigned this Feb 7, 2024
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
refactor(webconnectivitylte): use NewHTTPTransportWithOptions
58b6f93 
There's no need to use the older NewHTTPTransport factory for creating
a new HTTP transport, because this codebase doesn't need to use any quirk
implemented by such a transport.

While there, move TODOs around the codebase.

Part of ooni/probe#2669.
@bassosimone bassosimone mentioned this issue Feb 8, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
refactor(webconnectivitylte): use NewHTTPTransportWithOptions (#1494)
49382fe 
There's no need to use the older NewHTTPTransport factory for creating a
new HTTP transport, because this codebase doesn't need to use any quirk
implemented by such a transport.

While there, move TODOs around the codebase.

Part of ooni/probe#2669.
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
doc(webconnectivitylte): clarify http_transaction_{start,end} semantics
b30253b 
Part of ooni/probe#2669
@bassosimone bassosimone mentioned this issue Feb 8, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
doc(webconnectivitylte): clarify http_transaction_{start,end} semanti…
37db467 
…cs (#1495)

Part of ooni/probe#2669
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
refactor: move webconnectivitylte algos to webconnectivityalgo
b015590 
This diff refactors webconnectivitylte by moving some algorithms inside
the new webconnectivityalgo package.

In subsequent commits, we'll seize the opportunity of adding tests for
these algorithms, refactor the code, and add specific tests.

Part of ooni/probe#2669.

While there, recognize that the webconnectivityqa package does not
belong to internal/experiment but to internal.
@bassosimone bassosimone mentioned this issue Feb 8, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
refactor: move webconnectivitylte algos to webconnectivityalgo (#1496)
a6f3ca4 
This diff refactors webconnectivitylte by moving some algorithms inside
the new webconnectivityalgo package.

In subsequent commits, we'll seize the opportunity of adding tests for
these algorithms, refactor the code, and add specific tests.

Part of ooni/probe#2669.

While there, recognize that the webconnectivityqa package does not
belong to internal/experiment but to internal.
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
feat(webconnectivityalgo): test OpportunisticDNSOverHTTPSURLProvider
cb01355 
Part of ooni/probe#2669
@bassosimone bassosimone mentioned this issue Feb 8, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
feat(webconnectivityalgo): test OpportunisticDNSOverHTTPSURLProvider (#…
7355ba0 
…1497)

Part of ooni/probe#2669
bassosimone added a commit to ooni/netem that referenced this issue Feb 8, 2024
@bassosimone
feat: implement whoami.v4.powerdns.org
72f8b78 
Part of ooni/probe#2669
@bassosimone bassosimone mentioned this issue Feb 8, 2024
Merged
bassosimone added a commit to ooni/netem that referenced this issue Feb 8, 2024
@bassosimone
feat: implement whoami.v4.powerdns.org (#47)
608dcbc 
Part of ooni/probe#2669
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
feat(webconnectivityalgo): test DNSWhoamiService
c4bf2b1 
Part of ooni/probe#2669
@bassosimone bassosimone mentioned this issue Feb 8, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
feat(webconnectivityalgo): test DNSWhoamiService (#1498)
9c6cc44 
Part of ooni/probe#2669
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
fix(DNSWhoamiService): implement cache expiration
46046c1 
Because the singleton is always active, we need to expire the cache
otherwise we don't catch changes in the client network.

Part of ooni/probe#2669
@bassosimone bassosimone mentioned this issue Feb 8, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
fix(DNSWhoamiService): implement cache expiration (#1499)
576aa23 
Because the singleton is always active, we need to expire the cache
otherwise we don't catch changes in the client network.

Part of ooni/probe#2669

Closes ooni/probe#2671
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
feat(webconnectivitylte): cycle through DNS-over-UDP resolvers
05fb9dd 
Cycling through resolvers has been requested by some users recently.

While there address all the remaining TODOs.

Closes ooni/probe#2669.
@bassosimone bassosimone mentioned this issue Feb 8, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
feat(webconnectivitylte): use random DNS-over-UDP resolver (#1500)
2e43eea 
Using one resolver at random from a pool of some has been requested by
users.

While there link all the remaining TODOs to existing open issues.

Closes ooni/probe#2669.

Here are three measurements showcasing this new feature:

1. [using
1.0.0.1:53](https://explorer.ooni.org/m/20240208153440.990674_IT_webconnectivity_646b76338342a1a8)
2. [using
1.1.1.1:53](https://explorer.ooni.org/m/20240208154552.863516_IT_webconnectivity_97c3ed1a6bbebd5e)
3. [using
9.9.9.9:53](https://explorer.ooni.org/m/20240208154616.549959_IT_webconnectivity_2515d794df2ebd34)
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
refactor(webconnectivitylte): use NewHTTPTransportWithOptions (ooni#1494
b9ec11a 
)

There's no need to use the older NewHTTPTransport factory for creating a
new HTTP transport, because this codebase doesn't need to use any quirk
implemented by such a transport.

While there, move TODOs around the codebase.

Part of ooni/probe#2669.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
doc(webconnectivitylte): clarify http_transaction_{start,end} semanti…
013513c 
…cs (ooni#1495)

Part of ooni/probe#2669
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
refactor: move webconnectivitylte algos to webconnectivityalgo (ooni#…
1bec4e0 
…1496)

This diff refactors webconnectivitylte by moving some algorithms inside
the new webconnectivityalgo package.

In subsequent commits, we'll seize the opportunity of adding tests for
these algorithms, refactor the code, and add specific tests.

Part of ooni/probe#2669.

While there, recognize that the webconnectivityqa package does not
belong to internal/experiment but to internal.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
feat(webconnectivityalgo): test OpportunisticDNSOverHTTPSURLProvider (o…
fed3ea1 
…oni#1497)

Part of ooni/probe#2669
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
feat(webconnectivityalgo): test DNSWhoamiService (ooni#1498)
21bcf7e 
Part of ooni/probe#2669
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
fix(DNSWhoamiService): implement cache expiration (ooni#1499)
ab5a1cb 
Because the singleton is always active, we need to expire the cache
otherwise we don't catch changes in the client network.

Part of ooni/probe#2669

Closes ooni/probe#2671
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
feat(webconnectivitylte): use random DNS-over-UDP resolver (ooni#1500)
67d120c 
Using one resolver at random from a pool of some has been requested by
users.

While there link all the remaining TODOs to existing open issues.

Closes ooni/probe#2669.

Here are three measurements showcasing this new feature:

1. [using
1.0.0.1:53](https://explorer.ooni.org/m/20240208153440.990674_IT_webconnectivity_646b76338342a1a8)
2. [using
1.1.1.1:53](https://explorer.ooni.org/m/20240208154552.863516_IT_webconnectivity_97c3ed1a6bbebd5e)
3. [using
9.9.9.9:53](https://explorer.ooni.org/m/20240208154616.549959_IT_webconnectivity_2515d794df2ebd34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
funder/otffoss2023-2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(webconnectivitylte): use random DNS-over-UDP resolver ooni/probe-cli
1 participant
@bassosimone