Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement whoami.v4.powerdns.org #47

Merged
merged 2 commits into from
Feb 8, 2024
Merged

feat: implement whoami.v4.powerdns.org #47

merged 2 commits into from
Feb 8, 2024

Conversation

bassosimone
Copy link
Contributor

Part of ooni/probe#2669

bassosimone
bassosimone commented Feb 8, 2024
View reviewed changes
example_star_test.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7827770270

  • -2 of 23 (91.3%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 84.927%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dnsserver.go 21 23 91.3%
Files with Coverage Reduction New Missed Lines %
ndt0.go 3 94.0%
Totals Coverage Status
Change from base Build 7789156196: -0.06%
Covered Lines: 2451
Relevant Lines: 2886
💛 - Coveralls

@bassosimone bassosimone merged commit 608dcbc into main Feb 8, 2024
4 checks passed
@bassosimone bassosimone deleted the issue/2669e branch February 8, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bassosimone @coveralls