Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report: Equivalent class with no genus check #865

Merged
merged 8 commits into from
Aug 13, 2021
Merged

Report: Equivalent class with no genus check #865

merged 8 commits into from
Aug 13, 2021

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented May 16, 2021

Resolves #844

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

See issue. What needs to be determined is whether we all agree this should be WARN or ERROR; there may be even some that would argue for INFO.

@matentzn matentzn changed the title Add new check: Equivalent class with no genus Add new check: Equivalent class with no genus WARN May 16, 2021
@matentzn matentzn changed the title Add new check: Equivalent class with no genus WARN Report: Equivalent class with no genus check May 16, 2021
@beckyjackson
Copy link
Contributor

beckyjackson commented May 17, 2021

I think this is a good check and the query works well. I'm not sure I like the word "genus" in the name of it though... is there a different word we can use?

Two (style) notes on the query:

  • You don't need to BIND an empty string to value. If you remove this line, the query will still return nothing for ?value.
  • You don't need to name ?ec, it can be rewritten as below. This isn't really a big deal, it's just a style thing that I like 🙂
?entity owl:equivalentClass [ rdf:type owl:Restriction ;
                              owl:someValuesFrom ?y ;
                              owl:onProperty ?property ] .

@beckyjackson
Copy link
Contributor

Oh, also please put the query in the report profile in alphabetical order. Thanks!

@matentzn
Copy link
Contributor Author

Ok, apart from the name, I think I dealt what you suggested! We also forget index.md again, but added it now.

@jamesaoverton jamesaoverton merged commit 2ed2001 into master Aug 13, 2021
@jamesaoverton jamesaoverton deleted the fix844 branch August 13, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: new ROBOT report check for logical definitions without a genus
3 participants