Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: new ROBOT report check for logical definitions without a genus #844

Closed
matentzn opened this issue Apr 13, 2021 · 2 comments · Fixed by #865
Closed

Suggestion: new ROBOT report check for logical definitions without a genus #844

matentzn opened this issue Apr 13, 2021 · 2 comments · Fixed by #865

Comments

@matentzn
Copy link
Contributor

matentzn commented Apr 13, 2021

I quite often see this:

A = R some C

This nearly always, if not always, points to an error. I suggest a new test:
Severity: WARN
Test:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>


SELECT DISTINCT ?entity ?property ?value ?y WHERE {
 ?entity owl:equivalentClass ?ec .
  ?ec rdf:type owl:Restriction .
  ?ec owl:someValuesFrom ?y .
  ?ec owl:onProperty ?property .
  FILTER (!isBlank(?entity))
  FILTER (!isBlank(?y))
  BIND("No genus in definition" as ?value)
ORDER BY ?entity
@matentzn
Copy link
Contributor Author

Note to self, this would break all phenotype ontologies. maybe reconsider. Closing for now but will perhaps revisit

@matentzn
Copy link
Contributor Author

Changed my mind. Will do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant