-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --strict flag #788
Add --strict flag #788
Conversation
@ignazio1977 made this comment in owlcs/owlapi#988:
Maybe this is a good test case to resolve that! (third-level nested annotation axioms) |
Indeed. There are unit tests for those in OWLAPI, I remember seeing plenty of info messages when debugging them. |
I looked through the docs and the code and I'm happy with it, but can we please have some sort of test? (Probably a unit test in this case.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great but please add some sort of unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please merge when you're ready.
Resolves #785
docs/
have been added/updatedmvn verify
says all tests passmvn site
says all JavaDocs correctCHANGELOG.md
has been updatedFirst pass at adding a
--strict
global flag that causes ROBOT to fail on unparsed triples. By default, unparsed triples will now be parsed as errors. I also added a hint about RDF reification ifrdfs:Statement
is found as an object.The
--strict
flag also turns on strict parsing with OWLAPI, but I couldn't find any documentation about what that means. If anybody (@ontodev/robot-team) knows where I can find those details (or has a brief summary) that would be great!Additionally, are there other examples of issues that cause unparsed triples? I'd like to make sure the documentation does a good job of explaining how to fix the issue.